Skip to content

Commit 2d84141

Browse files
committed
Fixed issue with case sensitive filenames when using the .vscodeangulartools setting file. Updated vis-network.min.js to latest v9.1.9. Fixes #441, fixes #442
1 parent 467a48c commit 2d84141

File tree

5 files changed

+18
-10
lines changed

5 files changed

+18
-10
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Change Log
22

3+
## Version 1.13.0
4+
5+
- Fixed issue with case sensitive filenames when using the .vscodeangulartools setting file.
6+
- Updated vis-network.min.js to latest v9.1.9
7+
- Maintenance: Bump packages to latest
8+
39
## Version 1.12.0
410

511
- Updated vis-network.min.js to latest v9.1.7

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,14 @@ Only the two parameters "includeFolders" and "excludeFolders" are used at the mo
116116

117117
If you add a includeFolders parameter, then only child folders of the folders in the list will be included. If you add a folder to the excludeFolders parameter then no files from the folder or its child-folders will be included.
118118

119+
Notice that the filename comparison from v1.13.0 is case-sensitive. This may affect Windows user because the Windows filesystem is not case sensitive and if you previously added a path then it may not work anymore. So if you experience that your graph is no longer rendered as it used to be, then it may be because your includeFolders paths have the wrong casing in the settings file.
120+
119121
Example:
122+
120123
```json
121124
{
122-
"includeFolders": "D:\\Src\\Angular-Examples\\angular8-example-app\\src",
123-
"excludeFolders": "D:\\Src\\Angular-Examples\\angular8-example-app\\src\\app\\shared"
125+
"includeFolders": "d:\\Src\\Angular-Examples\\angular8-example-app\\src",
126+
"excludeFolders": "d:\\Src\\Angular-Examples\\angular8-example-app\\src\\app\\shared"
124127
}
125128
```
126129

javascript/vis-network.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
"displayName": "AngularTools",
55
"description": "AngularTools is a collection of tools for exploring an Angular project, help you with documenting, reverse engineering a project or help when refactoring.",
66
"icon": "logo.png",
7-
"version": "1.12.0",
7+
"version": "1.13.0",
88
"license": "MIT",
99
"repository": "https://github.com/CoderAllan/vscode-angulartools",
1010
"author": {
1111
"name": "Allan Simonsen",
1212
"url": "https://github.com/CoderAllan"
1313
},
1414
"engines": {
15-
"vscode": "^1.83.0"
15+
"vscode": "^1.86.0"
1616
},
1717
"categories": [
1818
"Other",

src/filesystemUtils.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,11 @@ export class FileSystemUtils {
6464
let result: string[] = [];
6565
if (directories && directories.length > 0) {
6666
directories.forEach(directory => {
67-
directory = directory.toLowerCase();
6867
if (!settings.excludeDirectories.includes(path.basename(directory))) {
6968
let excludeDirectory = false;
7069
for (let i = 0; i < settings.excludeDirectories.length; i++) {
7170
let excludeDir = settings.excludeDirectories[i];
72-
if (directory.indexOf(excludeDir.toLowerCase()) >= 0) {
71+
if (directory.indexOf(excludeDir) >= 0) {
7372
excludeDirectory = true;
7473
break;
7574
}
@@ -81,7 +80,7 @@ export class FileSystemUtils {
8180
} else {
8281
for (let i = 0; i < settings.includeDirectories.length; i++) {
8382
let includeDir = settings.includeDirectories[i];
84-
if (directory.indexOf(includeDir.toLowerCase()) >= 0) {
83+
if (directory.indexOf(includeDir) >= 0) {
8584
result.push(directory);
8685
}
8786
}

0 commit comments

Comments
 (0)