chore(lint): tidy imports/types and wrap lines; finalize CLI UX

Author: CoderDeltaLAN

src/diff_risk_dashboard/cli.py

@@ -3,17 +3,17 @@
 import argparse
 import json
 import os
-from typing import Dict, Iterable, List, Mapping, Tuple
+from collections.abc import Iterable, Mapping
+from typing import Any
 
 from rich.console import Console
 from rich.panel import Panel
 from rich.table import Table
 
-from .report import Summary, SEVERITIES, to_markdown
+from .report import SEVERITIES, Summary, to_markdown
 
-
-SEV_ORDER: Tuple[str, ...] = tuple(SEVERITIES)
-SEV_TO_COLOR: Dict[str, str] = {
+SEV_ORDER: tuple[str, ...] = tuple(SEVERITIES)
+SEV_TO_COLOR: dict[str, str] = {
     "CRITICAL": "bold bright_red",
     "HIGH": "red3",
     "MEDIUM": "yellow3",
@@ -26,8 +26,10 @@ def _normalize(sev: str) -> str:
     return sev.strip().upper()
 
 
-def _count_by_severity_from_list(items: Iterable[Mapping[str, object]]) -> Dict[str, int]:
-    counts: Dict[str, int] = {k: 0 for k in SEVERITIES}
+def _count_by_severity_from_list(
+    items: Iterable[Mapping[str, Any]],
+) -> dict[str, int]:
+    counts: dict[str, int] = {k: 0 for k in SEVERITIES}
     for it in items:
         raw = it.get("severity") or it.get("level") or ""
         sev = _normalize(str(raw))
@@ -37,10 +39,10 @@ def _count_by_severity_from_list(items: Iterable[Mapping[str, object]]) -> Dict[
 
 
 def _build_summary(apv_obj: object) -> Summary:
-    # Soportar dos formas:
+    # Soporta:
     # 1) {"by_severity": {"HIGH": 1, ...}}
-    # 2) [ {"severity": "HIGH"}, ... ]
-    counts: Dict[str, int] = {k: 0 for k in SEVERITIES}
+    # 2) [{"severity": "HIGH"}, ...] o en "findings"/"items"
+    counts: dict[str, int] = {k: 0 for k in SEVERITIES}
 
     if isinstance(apv_obj, Mapping):
         bs = apv_obj.get("by_severity")
@@ -52,36 +54,34 @@ def _build_summary(apv_obj: object) -> Summary:
                         counts[kk] += int(v)  # type: ignore[arg-type]
                     except Exception:
                         pass
-        # fallback: lista en "findings" / "items"
         items = apv_obj.get("findings") or apv_obj.get("items")
         if isinstance(items, list) and not any(counts.values()):
             counts = _count_by_severity_from_list(items)  # type: ignore[arg-type]
     elif isinstance(apv_obj, list):
         counts = _count_by_severity_from_list(apv_obj)  # type: ignore[arg-type]
 
     total = sum(counts.values())
-    # peor severidad
+
     worst = "INFO"
     for sev in SEV_ORDER:
         if counts.get(sev, 0) > 0:
             worst = sev
             break
-    # nivel de riesgo
-    risk = "green"
+
     if worst in ("CRITICAL", "HIGH"):
         risk = "red"
     elif worst in ("MEDIUM", "LOW"):
         risk = "yellow"
+    else:
+        risk = "green"
 
     return Summary(total=total, by_severity=counts, worst=worst, risk_level=risk)
 
 
 def _load_input(s: str) -> object:
-    # Si existe ruta -> JSON desde archivo
     if os.path.isfile(s):
-        with open(s, "r", encoding="utf-8") as fh:
+        with open(s, encoding="utf-8") as fh:
             return json.load(fh)
-    # Si parece JSON inline ({ o [) -> parsear
     if s.lstrip().startswith("{") or s.lstrip().startswith("["):
         return json.loads(s)
     raise SystemExit(f"✗ Not found and not JSON: {s}")
@@ -90,13 +90,21 @@ def _load_input(s: str) -> object:
 def _render_table(summary: Summary, console: Console) -> None:
     if summary.total == 0:
         console.print(
-            Panel.fit("✅ No findings", border_style="green", title="Diff Risk Dashboard")
+            Panel.fit(
+                "✅ No findings",
+                border_style="green",
+                title="Diff Risk Dashboard",
+            )
         )
         return
 
-    title_dot = (
-        "🔴" if summary.risk_level == "red" else "🟡" if summary.risk_level == "yellow" else "🟢"
-    )
+    if summary.risk_level == "red":
+        title_dot = "🔴"
+    elif summary.risk_level == "yellow":
+        title_dot = "🟡"
+    else:
+        title_dot = "🟢"
+
     table = Table(
         title=f"Diff Risk Dashboard {title_dot} — Worst: {summary.worst}",
         title_justify="center",
@@ -110,7 +118,6 @@ def _render_table(summary: Summary, console: Console) -> None:
     table.add_column("Bar")
 
     total = max(1, summary.total)
-    # ancho aproximado para barra proporcional
     bar_width = max(10, min(48, console.size.width - 60))
 
     for sev in SEVERITIES:
@@ -122,7 +129,10 @@ def _render_table(summary: Summary, console: Console) -> None:
 
     table.add_row("TOTAL", str(summary.total), "100%" if summary.total else "0%", "")
     console.print(table)
-    console.print("Tip: usa  -f md  para reporte Markdown o  -f json  para máquinas.", style="dim")
+    console.print(
+        "Tip: usa  -f md  para reporte Markdown o  -f json  para máquinas.",
+        style="dim",
+    )
 
 
 def _render_bars(summary: Summary) -> None:
@@ -138,10 +148,9 @@ def _render_bars(summary: Summary) -> None:
 
 
 def main() -> None:
-    p = argparse.ArgumentParser(
-        prog="diff_risk_dashboard", description="Diff Risk Dashboard (APV JSON -> summary)"
-    )
-    p.add_argument("input", help="File path or inline JSON from ai-patch-verifier")
+    desc = "Diff Risk Dashboard (APV JSON -> summary)"
+    p = argparse.ArgumentParser(prog="diff_risk_dashboard", description=desc)
+    p.add_argument("input", help="File path or inline JSON")
     p.add_argument(
         "-f",
         "--format",
@@ -151,7 +160,9 @@ def main() -> None:
     )
     p.add_argument("-o", "--output", default="-", help="Output file; '-' = stdout")
     p.add_argument(
-        "--no-exit-by-risk", action="store_true", help="Do not set exit code by risk level"
+        "--no-exit-by-risk",
+        action="store_true",
+        help="Do not set exit code by risk level",
     )
     args = p.parse_args()
 
@@ -183,11 +194,10 @@ def main() -> None:
     elif args.format == "bar":
         _render_bars(summary)
 
-    else:  # table (TTY pretty)
+    else:  # table
         console = Console(force_jupyter=False, force_terminal=None, soft_wrap=False)
         _render_table(summary, console)
 
-    # Exit code unless overridden
     if not args.no_exit_by_risk:
         if summary.risk_level == "red":
             raise SystemExit(2)

src/diff_risk_dashboard/report.py

@@ -1,13 +1,12 @@
 from dataclasses import dataclass
-from typing import Dict, List
 
-SEVERITIES: List[str] = ["CRITICAL", "HIGH", "MEDIUM", "LOW", "INFO"]
+SEVERITIES: list[str] = ["CRITICAL", "HIGH", "MEDIUM", "LOW", "INFO"]
 
 
 @dataclass
 class Summary:
     total: int
-    by_severity: Dict[str, int]
+    by_severity: dict[str, int]
     worst: str
     risk_level: str  # "red" | "yellow" | "green"
 
@@ -22,7 +21,7 @@ def to_markdown(s: Summary) -> str:
         )
 
     dot = "🔴" if s.risk_level == "red" else "🟡" if s.risk_level == "yellow" else "🟢"
-    lines = [
+    lines: list[str] = [
         f"# Diff Risk Dashboard {dot} — Worst: **{s.worst}**",
         "",
         "| Severity | Count |",