Remove unnecessary usertype check when inviting ninja

Author: DanielBrierton

config/perm/profiles.js

@@ -178,8 +178,7 @@ module.exports = function(){
       },
       {
         role: 'basic-user',
-        userType: 'champion',
-        extendedUserTypes: true
+        userType: 'champion'
       },
       {
         role: 'basic-user',

profiles.js

@@ -1020,7 +1020,6 @@ module.exports = function (options) {
       // Ninja should have attendee-o13 user type.
       async.series([
         validateRequestingUserIsNotParentOfNinja,
-        validateRequestingUserIsParent,
         validateNinjaEmailExists,
         validateNinjaHasAttendeeO13UserType
       ], done);
@@ -1035,28 +1034,6 @@ module.exports = function (options) {
         });
       }
 
-      function validateRequestingUserIsParent (done) {
-        var userId = args.user ? args.user.id : null;
-        seneca.act({role: 'cd-dojos', cmd: 'load_usersdojos', query: {userId: userId}}, function (err, usersDojos) {
-          if (err) return done(err);
-          if (_.isEmpty(usersDojos)) {
-            // Not yet a member of any Dojo, check the user type in their profile.
-            seneca.act({role: plugin, cmd: 'list'}, {query: {userId: userId}}, function (err, parentProfiles) {
-              if (err) return done(err);
-              var parentProfile = parentProfiles[0];
-              if (parentProfile.userType === 'parent-guardian') return done();
-              return done(new Error('You must be a parent to invite a Ninja'));
-            });
-          } else {
-            var parentTypeFound = _.find(usersDojos, function (parentUserDojo) {
-              return _.contains(parentUserDojo.userTypes, 'parent-guardian');
-            });
-            if (parentTypeFound) return done();
-            return done(new Error('You must be a parent to invite a Ninja'));
-          }
-        });
-      }
-
       function validateNinjaEmailExists (done) {
         seneca.act({role: plugin, cmd: 'list', query: {email: ninjaEmail}}, function (err, ninjaProfiles) {
           if (err) return done(err);