Bugfix/add logs to failed perms (#231)

* Add logs to monitor permissions issues

* Remove rogue console

* Renaming logger->logFormatter

Author: Wardormeur

lib/custom-validator-log-formatter.js

@@ -0,0 +1,11 @@
+'use strict';
+module.exports = function customValidatorLogFormatter (ms, cmd, err, args) {
+  return JSON.stringify({
+    src: {
+      ms: ms,
+      cmd: cmd
+    },
+    err: err,
+    args: args
+  });
+};

lib/profiles/is-own-profile.js

@@ -8,11 +8,14 @@ function isOwnProfile (args, cb) {
   var plugin = args.role;
   var userId = args.user.id;
   var refProfileId = args.params.profileId || args.params.id ;
-  seneca.act({role: 'cd-profiles', cmd: 'load_user_profile', userId: userId}, function(err, profile){
-    if (err) return done(null, {'allowed': false});
+  seneca.act({role: 'cd-profiles', cmd: 'load_user_profile', userId: userId}, function (err, profile) {
+    if (err) {
+      seneca.log.error(seneca.customValidatorLogFormatter('cd-profiles', 'isOwnProfile', err, {userId: userId, refProfileId: refProfileId}));
+      return cb(null, {'allowed': false});
+    }
     var isSelf = false;
     // Could check upon profile, but seems like an overkill to me
-    if( profile.id === refProfileId ){
+    if (profile.id === refProfileId) {
       isSelf = true;
     }
     return cb(null, {'allowed': isSelf});

lib/users/is-parent-of.js

@@ -7,15 +7,19 @@ function isParentOf (args, cb) {
   var seneca = this;
   var plugin = args.role;
   var userId = args.user.id;
-  var childrenId = args.params.userId
+  var childrenId = args.params.userId;
   if(_.isUndefined(childrenId) && args.params.profile) childrenId = args.params.profile.userId;
   if(_.isUndefined(childrenId) && args.params.query) childrenId = args.params.query.userId;
   var isParent = false;
   //  Could also check the opposite way, from child to Parent
   seneca.act({role: 'cd-profiles', cmd: 'load_user_profile', userId: userId},
-    function(err, user){
-      if(err) return cb(null, {'allowed': false});
-      if(_.includes(user.children, childrenId )) isParent = true;
+    function (err, user) {
+      if (err) {
+        seneca.log.error(seneca.customValidatorLogFormatter('cd-profiles', 'isParentOf', err, {userId: userId, childrenId: childrenId}));
+        return cb(null, {'allowed': false});
+      }
+
+      if (_.includes(user.children, childrenId )) isParent = true;
       return cb(null, {'allowed': isParent});
   });
 }

service.js

@@ -17,7 +17,7 @@ var dgram = require('dgram');
 seneca.log.info('using config', JSON.stringify(config, null, 4));
 
 seneca.options(config);
-
+seneca.decorate('customValidatorLogFormatter', require('./lib/custom-validator-log-formatter'));
 seneca.use(store, config['postgresql-store']);
 if (process.env.MAILTRAP_ENABLED === 'true') {
   seneca.use('mail', config.mailtrap);