Fix permissions algorythm (8) to update youth when you're o13 (#201)

Author: Wardormeur

lib/users/is-self.js

@@ -8,8 +8,12 @@ function isSelf (args, cb) {
   var plugin = args.role;
   var userId = args.user.id;
   var refUserId = args.params.userId || args.params.id ;
-  if(args.params.query && _.isUndefined(refUserId))
+  if (args.params.query && _.isUndefined(refUserId)) {
     refUserId = args.params.query.userId || args.params.query.id ;
+  }
+  if (args.params.profile && _.isUndefined(refUserId)) {
+    refUserId = args.params.profile.userId;
+  }
   var isSelf = false;
   // Could check upon profile, but seems like an overkill to me
   if( userId === refUserId ){

profiles.js

@@ -305,10 +305,6 @@ module.exports = function (options) {
   }
 
   function cmd_update_youth (args, done) {
-    var userId = args.user ? args.user.id : null;
-    if (!_.contains(args.profile.parents, userId)) {
-      return done(new Error('Not authorized to update profile'));
-    }
     var profile = args.profile;
     var derivedFields = ['password', 'userTypes', 'myChild', 'ownProfileFlag', 'dojos'];