Better salt for user (#206)

also, doesn't crash on postgres when NULL byte is generated

Author: Wardormeur

package.json

@@ -27,6 +27,7 @@
     "async": "0.9.0",
     "cp-i18n-lib": "git+https://github.com/CoderDojo/cp-i18n-lib.git",
     "cp-logs-lib": "git://github.com/CoderDojo/cp-logs-lib#v1.0.1",
+    "cp-permissions-plugin": "git://github.com/CoderDojo/cp-permissions-plugin#0.0.1",
     "cuid": "1.2.5",
     "ejs": "1.0.0",
     "jed": "1.1.0",
@@ -46,7 +47,6 @@
     "seneca-auth": "1.0",
     "seneca-mail": "0.2.1",
     "seneca-postgresql-store": "1.1.3",
-    "cp-permissions-plugin": "git://github.com/CoderDojo/cp-permissions-plugin#0.0.1",
     "seneca-user": "1.0",
     "shortid": "2.2.2",
     "util": "^0.10.3",

users.js

@@ -5,6 +5,7 @@ var async = require('async');
 var request = require('request');
 var moment = require('moment');
 var pg = require('pg');
+var crypto = require('crypto');
 
 module.exports = function (options) {
   var seneca = this;
@@ -35,6 +36,14 @@ module.exports = function (options) {
   seneca.add({role: 'cd-users', cmd: 'is_self'}, require('./lib/users/is-self'));
   seneca.add({role: 'cd-users', cmd: 'is_parent_of'}, require('./lib/users/is-parent-of'));
 
+  seneca.add({role: 'user', cmd: 'encrypt_password'}, function (data, cb) {
+    //  Default seneca's salt is 16b length (too small entropy) and can generate NULL char, which pg cannot handle
+    if (_.isUndefined(data.salt)) {
+      data.salt = crypto.randomBytes(256).toString('hex');
+    }
+    this.prior(data, cb);
+  });
+
   function cmd_load_prev_founder (args, done) {
     var seneca = this;
     seneca.act({role: plugin, cmd: 'load', id: args.id}, function (err, user) {