Skip to content
This repository was archived by the owner on Dec 14, 2023. It is now read-only.

Commit 741c7ce

Browse files
authored
Ensure we display that a Dojo is inactive (#252)
* Ensure we display that a Dojo is inactive * Linting * Bump cp-translations
1 parent f533474 commit 741c7ce

File tree

4 files changed

+49
-6
lines changed

4 files changed

+49
-6
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"dependencies": {
2323
"@coderdojo/cd-common": "1.1.11",
2424
"bootstrap": "^3.4.1",
25-
"cp-translations": "1.0.128",
25+
"cp-translations": "1.0.130",
2626
"font-awesome": "^4.7.0",
2727
"handlebars": "^4.1.0",
2828
"js-cookie": "^2.1.4",

src/dojos/cd-dojo-details.vue

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<a v-if="dojoDetails.googleGroup" class="cd-dojo-details__social-media-icon fa fa-2x fa-google cd-dojo-details__google-group sm-icon" aria-hidden="true" :href="dojoDetails.googleGroup"></a>
3232
</info-column-section>
3333
</info-column>
34-
<div class="cd-dojo-details__main_content">
34+
<div class="cd-dojo-details__main_content" v-if="isActive">
3535
<dropdown v-if="isDojoAdmin || isTicketingAdmin" class="cd-dojo-details__settings-dropdown" icon="gear" align="right">
3636
<li v-if="isDojoAdmin"><a :href="`/dashboard/edit-dojo/${dojoDetails.id}`"><i class="fa fa-pencil"></i>{{ $t('Edit Dojo') }}</a></li>
3737
<li v-if="isDojoAdmin"><a :href="`/dashboard/my-dojos/${dojoDetails.id}/users`"><i class="fa fa-users"></i>{{ $t('Manage Users') }}</a></li>
@@ -87,6 +87,10 @@
8787
</div>
8888
</section>
8989
</div>
90+
<div class="cd-dojo-details__main_content" v-else>
91+
<h2>{{ $t('This Dojo is now inactive.') }}</h2>
92+
<h3 v-html="$t('Click {openLink}here{closeLink} to look for an active Dojo.',{ openLink: `<a href='/find'>`, closeLink: '</a>' })"></h3>
93+
</div>
9094
</div>
9195
</div>
9296
</template>
@@ -210,6 +214,9 @@
210214
isTicketingAdmin() {
211215
return this.isCDFAdmin || UsersDojosUtil.hasPermission(this.usersDojos, 'ticketing-admin');
212216
},
217+
isActive() {
218+
return !this.dojoDetails.deleted && this.dojoDetails.stage !== 4;
219+
},
213220
},
214221
methods: {
215222
async loadDojoDetails() {

test/unit/specs/dojos/cd-dojo-details.spec.js

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,42 @@ describe('Dojo details component', () => {
122122
});
123123
});
124124

125+
describe('computed.isActive', () => {
126+
it('should return true', () => {
127+
// ARRANGE
128+
const vm = vueUnitHelper(DojoDetailsWithMocks);
129+
vm.dojoDetails = {
130+
stage: 1,
131+
deleted: 0,
132+
};
133+
134+
// ASSERT
135+
expect(vm.isActive).to.be.true;
136+
});
137+
it('should return false if the dojo is deleted', () => {
138+
// ARRANGE
139+
const vm = vueUnitHelper(DojoDetailsWithMocks);
140+
vm.dojoDetails = {
141+
stage: 1,
142+
deleted: 1,
143+
};
144+
145+
// ASSERT
146+
expect(vm.isActive).to.be.false;
147+
});
148+
it('should return false if the stage is inactive', () => {
149+
// ARRANGE
150+
const vm = vueUnitHelper(DojoDetailsWithMocks);
151+
vm.dojoDetails = {
152+
stage: 4,
153+
deleted: 0,
154+
};
155+
156+
// ASSERT
157+
expect(vm.isActive).to.be.false;
158+
});
159+
});
160+
125161
describe('computed.urlSlug', () => {
126162
it('should build the urlSlug from path parameters', () => {
127163
// ARRANGE

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1988,10 +1988,10 @@ cosmiconfig@^2.1.0, cosmiconfig@^2.1.1:
19881988
parse-json "^2.2.0"
19891989
require-from-string "^1.1.0"
19901990

1991-
1992-
version "1.0.128"
1993-
resolved "https://registry.yarnpkg.com/cp-translations/-/cp-translations-1.0.128.tgz#2f7c5f09997e44a0137e976263e3a1779d747e07"
1994-
integrity sha512-gpIIvn9sjSyGpWPwYoFwMZQSKdaZuFY7y3F/72W0nwW9LJOFbK1yN8q2je3udYAtVHNOX0XlHuLQpRAo8yCx2A==
1991+
1992+
version "1.0.130"
1993+
resolved "https://registry.yarnpkg.com/cp-translations/-/cp-translations-1.0.130.tgz#0b0063ba53e398d56005de30b58bc216f8c03f18"
1994+
integrity sha512-nRdYKAjo5BZXs0iJtyubgdlZEDaD8rt1XPfzFjv6Z2lllszhcoOiW0LyF+VPAJBvbh8rlQceUQXdMlhgAXwf6w==
19951995

19961996
crc32-stream@^2.0.0:
19971997
version "2.0.0"

0 commit comments

Comments
 (0)