Skip to content
This repository was archived by the owner on Dec 14, 2023. It is now read-only.

Commit 96575fd

Browse files
committed
Fix error message not being shown on login.
API has changed, an object is passed not a string.
1 parent 7ed6c79 commit 96575fd

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/users/cd-login.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@
8181
if (valid) {
8282
const response = await UserService.login(this.email, this.password);
8383
if (response.body.ok === false) {
84-
this.errors.add('loginFailed', response.body.why);
84+
this.errors.add({
85+
field: 'loginFailed',
86+
msg: response.body.why });
8587
} else {
8688
const forumUrl = `^${Vue.config.forumsUrlBase}/auth/CoderDojo$`;
8789
if (this.redirectUrl.match(forumUrl)) {

test/unit/specs/users/cd-login.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ describe('Login', () => {
142142
await vm.login();
143143

144144
// ASSERT
145-
expect(vm.errors.add).to.have.been.calledWith('loginFailed');
145+
expect(vm.errors.add).to.have.been.calledWith({ field: 'loginFailed', msg: undefined });
146146
expect(vm.$router.push).to.not.have.been.called;
147147
});
148148

0 commit comments

Comments
 (0)