refactor: public API marking, extended compiler features, and private mangling (#2349)

Author: Danielku15

package.json

@@ -9,8 +9,8 @@
     ],
     "scripts": {
         "clean": "npm run clean --workspaces --if-present",
-        "lint": "npm run lint-ci --workspaces --if-present",
-        "lint-ci": "npm run lint-ci --workspaces --if-present -- --reporter=github",
+        "lint": "npm run lint --workspaces --if-present",
+        "lint-ci": "npm run lint --workspaces --if-present -- --reporter=github",
         "typecheck": "npm run typecheck --workspaces --if-present",
         "dev": "npm run dev --workspace=packages/playground",
 

packages/alphatab/biome.jsonc

@@ -18,17 +18,80 @@
             "src/**",
             "test/**",
             "src.compiler/**",
-            "playground/**",
-            "playground-template/**"
+            "playground/**"
         ]
     },
     "linter": {
         "includes": [
             "*.ts",
             "src/**",
             "test/**",
-            "src.compiler/**",
-            "playground-template/**"
-        ]
+            "src.compiler/**"
+        ],
+        "rules": {
+            "style": {
+                "useNamingConvention": {
+                    "level": "error",
+                    "options": {
+                        "strictCase": false,
+                        "conventions": [
+                            {
+                                "selector": {
+                                    "kind": "classMember",
+                                    "modifiers": [
+                                        "private"
+                                    ]
+                                },
+                                "match": "_(.+)",
+                                "formats": [
+                                    "camelCase"
+                                ]
+                            },
+                            {
+                                "selector": {
+                                    "kind": "objectLiteralProperty"
+                                },
+                                "formats": [
+                                    "camelCase",
+                                    "PascalCase"
+                                ]
+                            },
+                            {
+                                "selector": {
+                                    "kind": "typeProperty"
+                                },
+                                "formats": [
+                                    "camelCase",
+                                    "PascalCase"
+                                ]
+                            },
+                            {
+                                "selector": {
+                                    "kind": "classProperty",
+                                    "modifiers": [
+                                        "static",
+                                        "readonly"
+                                    ]
+                                },
+                                "formats": [
+                                    "camelCase",
+                                    "PascalCase"
+                                ]
+                            },
+                            {
+                                "selector": {
+                                    "kind": "enumMember"
+                                },
+                                "match": ".+",
+                                "formats": [
+                                    "PascalCase",
+                                    "CONSTANT_CASE"
+                                ]
+                            }
+                        ]
+                    }
+                }
+            }
+        }
     }
 }

packages/alphatab/scripts/CloneEmitter.ts

@@ -17,6 +17,10 @@ function toImportPath(fileName: string) {
 }
 
 function isCloneMember(propertyDeclaration: ts.PropertyDeclaration) {
+    if (ts.isPrivateIdentifier(propertyDeclaration.name)){
+        return false;
+    }
+
     if (propertyDeclaration.modifiers) {
         if (
             propertyDeclaration.modifiers.find(
@@ -347,16 +351,20 @@ export default createEmitter('cloneable', (program, input) => {
         );
     }
 
-    statements.push(
-        ts.factory.createClassDeclaration(
+    const clz = ts.addSyntheticLeadingComment(ts.factory.createClassDeclaration(
             [ts.factory.createModifier(ts.SyntaxKind.ExportKeyword)],
             `${input.name!.text}Cloner`,
             undefined,
             undefined,
             [createCloneMethod(program, input, importer)]
-        )
+        ),
+        ts.SyntaxKind.MultiLineCommentTrivia,
+        '*\n * @internal\n ',
+        true
     );
 
+    statements.push(clz);
+
     const sourceFile = ts.factory.createSourceFile(
         [
             ts.factory.createImportDeclaration(

packages/alphatab/scripts/SerializerEmitter.ts

@@ -43,8 +43,7 @@ export default createEmitter('json', (program, input) => {
         );
     }
 
-    statements.push(
-        ts.factory.createClassDeclaration(
+    const clz = ts.addSyntheticLeadingComment(ts.factory.createClassDeclaration(
             [ts.factory.createModifier(ts.SyntaxKind.ExportKeyword)],
             `${input.name!.text}Serializer`,
             undefined,
@@ -54,9 +53,14 @@ export default createEmitter('json', (program, input) => {
                 createToJsonMethod(input, serializable, importer),
                 createSetPropertyMethod(input, serializable, importer)
             ]
-        )
+        ),
+        ts.SyntaxKind.MultiLineCommentTrivia,
+        '*\n * @internal\n ',
+        true
     );
 
+    statements.push(clz);
+
     const sourceFile = ts.factory.createSourceFile(
         [
             ts.factory.createImportDeclaration(

packages/alphatab/scripts/generate-typescript.ts

@@ -36,7 +36,9 @@ fs.writeSync(
     `\
 ${GENERATED_FILE_HEADER}
 
-
+/**
+ * @internal
+ */ 
 export class VersionInfo {
     public static readonly version: string = '${version}';
     public static readonly date: string = '${new Date().toISOString()}';