Skip to content

Commit 0f41289

Browse files
kinarobinwolfcon
authored andcommitted
Rename mj_keyValuesDidFinishConvertingToObject method (#707)
* deprecated converting to object method * rename `didFinishConvertingTo` with `didConvertTo` * rename `objectDidFinishConverting` with `objectDidConvert` * add parameter for `mj_objectDidConvertToKeyValues` method
1 parent d567965 commit 0f41289

File tree

4 files changed

+21
-6
lines changed

4 files changed

+21
-6
lines changed

MJExtension/MJExtensionConst.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,15 @@ MJExtensionAssert2((param) != nil, returnValue)
7777
* 打印所有的属性
7878
*/
7979
#define MJLogAllIvars \
80-
-(NSString *)description \
80+
- (NSString *)description \
8181
{ \
8282
return [self mj_keyValues].description; \
8383
}
8484
#define MJExtensionLogAllProperties MJLogAllIvars
8585

8686
/** 仅在 Debugger 展示所有的属性 */
8787
#define MJImplementDebugDescription \
88-
-(NSString *)debugDescription \
88+
- (NSString *)debugDescription \
8989
{ \
9090
return [self mj_keyValues].debugDescription; \
9191
}

MJExtension/MJProperty.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ - (id)valueForObject:(id)object
8181
/** https://github.com/CoderMJLee/MJExtension/issues/545 */
8282
// 32 bit device OR 32 bit Simulator
8383
#if defined(__arm__) || (TARGET_OS_SIMULATOR && !__LP64__)
84-
if(self.type.isBoolType) {
84+
if (self.type.isBoolType) {
8585
value = @([(NSNumber *)value boolValue]);
8686
}
8787
#endif

MJExtension/NSObject+MJKeyValue.h

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,16 @@
5959
/**
6060
* 当字典转模型完毕时调用
6161
*/
62-
- (void)mj_keyValuesDidFinishConvertingToObject;
63-
- (void)mj_keyValuesDidFinishConvertingToObject:(NSDictionary *)keyValues;
62+
- (void)mj_keyValuesDidFinishConvertingToObject MJExtensionDeprecated("请使用`mj_didConvertToObjectWithKeyValues:`替代");
63+
- (void)mj_keyValuesDidFinishConvertingToObject:(NSDictionary *)keyValues MJExtensionDeprecated("请使用`mj_didConvertToObjectWithKeyValues:`替代");
64+
- (void)mj_didConvertToObjectWithKeyValues:(NSDictionary *)keyValues;
6465

6566
/**
6667
* 当模型转字典完毕时调用
6768
*/
68-
- (void)mj_objectDidFinishConvertingToKeyValues;
69+
- (void)mj_objectDidFinishConvertingToKeyValues MJExtensionDeprecated("请使用`mj_objectDidConvertToKeyValues:`替代");
70+
- (void)mj_objectDidConvertToKeyValues:(NSDictionary *)keyValues;
71+
6972
@end
7073

7174
@interface NSObject (MJKeyValue) <MJKeyValue>

MJExtension/NSObject+MJKeyValue.m

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,12 +199,18 @@ - (instancetype)mj_setKeyValues:(id)keyValues context:(NSManagedObjectContext *)
199199
}];
200200

201201
// 转换完毕
202+
if ([self respondsToSelector:@selector(mj_didConvertToObjectWithKeyValues:)]) {
203+
[self mj_didConvertToObjectWithKeyValues:keyValues];
204+
}
205+
#pragma clang diagnostic push
206+
#pragma clang diagnostic ignored"-Wdeprecated-declarations"
202207
if ([self respondsToSelector:@selector(mj_keyValuesDidFinishConvertingToObject)]) {
203208
[self mj_keyValuesDidFinishConvertingToObject];
204209
}
205210
if ([self respondsToSelector:@selector(mj_keyValuesDidFinishConvertingToObject:)]) {
206211
[self mj_keyValuesDidFinishConvertingToObject:keyValues];
207212
}
213+
#pragma clang diagnostic pop
208214
return self;
209215
}
210216

@@ -400,9 +406,15 @@ - (NSMutableDictionary *)mj_keyValuesWithKeys:(NSArray *)keys ignoredKeys:(NSArr
400406
}];
401407

402408
// 转换完毕
409+
if ([self respondsToSelector:@selector(mj_objectDidConvertToKeyValues:)]) {
410+
[self mj_objectDidConvertToKeyValues:keyValues];
411+
}
412+
#pragma clang diagnostic push
413+
#pragma clang diagnostic ignored"-Wdeprecated-declarations"
403414
if ([self respondsToSelector:@selector(mj_objectDidFinishConvertingToKeyValues)]) {
404415
[self mj_objectDidFinishConvertingToKeyValues];
405416
}
417+
#pragma clang diagnostic pop
406418

407419
return keyValues;
408420
}

0 commit comments

Comments
 (0)