Fix some issues detected by PHPStan

Author: Coderberg

phpstan.dist.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 2
+    level: 5
     paths:
         - bin/
         - config/

src/Controller/Ajax/User/Security/GoogleAuthenticatorController.php

@@ -7,7 +7,6 @@
 use App\Controller\Ajax\AjaxController;
 use App\Entity\User;
 use App\Service\User\GoogleAuthenticatorService;
-use Scheb\TwoFactorBundle\Model\Google\TwoFactorInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
@@ -26,7 +25,7 @@ public function __construct(private readonly GoogleAuthenticatorService $service
     public function getAuthCode(): JsonResponse
     {
         try {
-            /** @var User|TwoFactorInterface $user */
+            /** @var User $user */
             $user = $this->getUser();
 
             return new JsonResponse($this->service->generateSecret($user));

src/Controller/Auth/ResetPasswordController.php

@@ -37,7 +37,7 @@ public function passwordReset(ResettingService $service, Request $request): Resp
     #[Route(path: '/password/reset/{token}', name: 'password_reset_confirm', methods: ['GET|POST'])]
     public function passwordResetConfirm(ResettingRepository $repository, Request $request, string $token): Response
     {
-        /** @var User $user */
+        /** @var ?User $user */
         $user = $repository->findOneBy(['confirmation_token' => $token]);
 
         if (!$user) {

src/Service/AbstractService.php

@@ -18,7 +18,12 @@ abstract class AbstractService
 
     public function __construct(private readonly CsrfTokenManagerInterface $tokenManager, RequestStack $requestStack)
     {
-        $this->session = $requestStack->getSession();
+        $session = $requestStack->getSession();
+
+        if (!$session instanceof FlashBagAwareSessionInterface) {
+            throw new \LogicException('Session must implement FlashBagAwareSessionInterface.');
+        }
+        $this->session = $session;
     }
 
     /**

src/Service/Admin/PageService.php

@@ -32,7 +32,7 @@ public function create(Page $page): void
         if (true === $page->getShowInMenu()) {
             $menu = new Menu();
             $menu->setTitle($page->getTitle() ?? '');
-            $menu->setLocale($page->getLocale() ?? '');
+            $menu->setLocale($page->getLocale());
             $menu->setUrl('/info/'.($page->getSlug() ?? ''));
             $this->save($menu);
         }

src/Validator/ConfirmPasswordValidator.php

@@ -10,7 +10,7 @@
 final class ConfirmPasswordValidator extends ConstraintValidator
 {
     /** @param ConfirmPassword $constraint */
-    public function validate($value, Constraint $constraint): void
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (null === $value || '' === $value) {
             return;

src/Validator/RegisteredUserValidator.php

@@ -16,7 +16,7 @@ public function __construct(private readonly UserRepository $userRepository)
     }
 
     /** @param RegisteredUser $constraint */
-    public function validate($value, Constraint $constraint): void
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (null === $value || '' === $value) {
             return;