Skip to content

Commit 3e0467c

Browse files
Backport PR jupyterlab#11339: Fix outdated clearSignalData reference (now Signal.clearData) (jupyterlab#11340)
Co-authored-by: Michał Krassowski <[email protected]>
1 parent 96d7722 commit 3e0467c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/source/developer/patterns.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ the payload. Signals should generally not be used to trigger the
8484
"default" behavior for an action, but to enable others to trigger
8585
additional behavior. If a "default" behavior is intended to be provided
8686
by another object, then a callback should be provided by that object.
87-
Wherever possible as signal connection should be made with the pattern
87+
Wherever possible a signal connection should be made with the pattern
8888
``.connect(this._onFoo, this)``. Providing the ``this`` context enables
89-
the connection to be properly cleared by ``clearSignalData(this)``.
89+
the connection to be properly cleared by ``Signal.clearData(this)``.
9090
Using a private method avoids allocating a closure for each connection.
9191

9292
Models

0 commit comments

Comments
 (0)