Backport PR jupyterlab#11370: Make orig_nbformat optional jupyterlab#11005 (jupyterlab#11384)

meeseeksmachine · fcollonval · web-flow · commit 9a45a3e15bf0 · 2021-11-03T18:48:28.000+01:00
Co-authored-by: Frédéric Collonval &lt;fcollonval@users.noreply.github.com&gt;
diff --git a/galata/src/galata.ts b/galata/src/galata.ts
@@ -292,8 +292,7 @@ export namespace galata {
             nbconvert_exporter: 'python',
             pygments_lexer: 'ipython3',
             version: '3.8.0'
-          },
-          orig_nbformat: 4
+          }
         },
         nbformat: 4,
         nbformat_minor: 4
diff --git a/packages/nbformat/src/index.ts b/packages/nbformat/src/index.ts
@@ -46,7 +46,7 @@ export interface ILanguageInfoMetadata extends PartialJSONObject {
 export interface INotebookMetadata extends PartialJSONObject {
   kernelspec?: IKernelspecMetadata;
   language_info?: ILanguageInfoMetadata;
-  orig_nbformat: number;
+  orig_nbformat?: number;
 }
 
 /**
diff --git a/packages/shared-models/src/ymodels.ts b/packages/shared-models/src/ymodels.ts
@@ -331,7 +331,7 @@ export class YNotebook
    */
   getMetadata(): nbformat.INotebookMetadata {
     const meta = this.ymeta.get('metadata');
-    return meta ? deepCopy(meta) : { orig_nbformat: 4 };
+    return meta ? deepCopy(meta) : {};
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export interface ILanguageInfoMetadata extends PartialJSONObject {`
`46`	`46`	`export interface INotebookMetadata extends PartialJSONObject {`
`47`	`47`	`kernelspec?: IKernelspecMetadata;`
`48`	`48`	`language_info?: ILanguageInfoMetadata;`
`49`		`- orig_nbformat: number;`
	`49`	`+ orig_nbformat?: number;`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ export class YNotebook`
`331`	`331`	`*/`
`332`	`332`	`getMetadata(): nbformat.INotebookMetadata {`
`333`	`333`	`const meta = this.ymeta.get('metadata');`
`334`		`- return meta ? deepCopy(meta) : { orig_nbformat: 4 };`
	`334`	`+ return meta ? deepCopy(meta) : {};`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`/**`