Skip to content

Commit c1321f5

Browse files
alemairebemuxator
authored andcommitted
remove devdeps from prod builds
1 parent cbd393d commit c1321f5

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

docker/Dockerfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ LABEL maintainer="Etherpad team, https://github.com/ether/etherpad-lite"
1313
# If not given, build the latest development version.
1414
ARG ETHERPAD_VERSION=develop
1515

16+
# Set the following to production to avoid installing devDeps
17+
# this can be one with build args (and is mandatory to build ARM version
18+
ARG NODE_ENV=development
19+
1620
# grab the ETHERPAD_VERSION tarball from github (no need to clone the whole
1721
# repository)
1822
RUN echo "Getting version: ${ETHERPAD_VERSION}" && \

docker/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ Build the version you prefer:
2222
docker build --tag <YOUR_USERNAME>/etherpad .
2323

2424
# builds latest stable version
25-
docker build --build-arg ETHERPAD_VERSION=master --tag <YOUR_USERNAME>/etherpad .
25+
docker build --build-arg ETHERPAD_VERSION=master --build-arg NODE_ENV=production --tag <YOUR_USERNAME>/etherpad .
2626

2727
# builds a specific version
28-
docker build --build-arg ETHERPAD_VERSION=1.7.5 --tag <YOUR_USERNAME>/etherpad .
28+
docker build --build-arg ETHERPAD_VERSION=1.7.5 --build-arg NODE_ENV=production --tag <YOUR_USERNAME>/etherpad .
2929

3030
# builds a specific git hash
3131
docker build --build-arg ETHERPAD_VERSION=4c45ac3cb1ae --tag <YOUR_USERNAME>/etherpad .

0 commit comments

Comments
 (0)