refactor: Use result type when fetching job URLs

Author: Codex-

src/api.spec.ts

@@ -451,8 +451,14 @@ describe("API", () => {
           vi.advanceTimersByTime(400);
           await vi.advanceTimersByTimeAsync(400);
 
-          const url = await urlPromise;
-          expect(url).toStrictEqual("Unable to fetch URL");
+          const result = await urlPromise;
+
+          if (result.success) {
+            expect.fail();
+          }
+
+          expect(result.success).toStrictEqual(false);
+          expect(result.reason).toStrictEqual("timeout");
 
           // Logging
           assertOnlyCalled(coreDebugLogMock);
@@ -506,8 +512,14 @@ describe("API", () => {
           vi.advanceTimersByTime(400);
           await vi.advanceTimersByTimeAsync(400);
 
-          const url = await urlPromise;
-          expect(url).toStrictEqual("Unable to fetch URL");
+          const result = await urlPromise;
+
+          if (result.success) {
+            expect.fail();
+          }
+
+          expect(result.success).toStrictEqual(false);
+          expect(result.reason).toStrictEqual("timeout");
 
           // Logging
           assertOnlyCalled(coreDebugLogMock);
@@ -542,8 +554,16 @@ describe("API", () => {
           vi.advanceTimersByTime(400);
           await vi.advanceTimersByTimeAsync(400);
 
-          const url = await urlPromise;
-          expect(url).toStrictEqual(inProgressMockData.jobs[0]?.html_url);
+          const result = await urlPromise;
+
+          if (!result.success) {
+            expect.fail();
+          }
+
+          expect(result.success).toStrictEqual(true);
+          expect(result.value).toStrictEqual(
+            inProgressMockData.jobs[0]?.html_url,
+          );
 
           // Logging
           assertOnlyCalled(coreDebugLogMock);

src/api.ts

@@ -210,14 +210,14 @@ export async function fetchWorkflowRunActiveJobUrl(
 export async function fetchWorkflowRunActiveJobUrlRetry(
   runId: number,
   timeout: number,
-): Promise<string> {
+): Promise<Result<string>> {
   const startTime = Date.now();
   let elapsedTime = Date.now() - startTime;
 
   while (elapsedTime < timeout) {
     const url = await fetchWorkflowRunActiveJobUrl(runId);
     if (url) {
-      return url;
+      return { success: true, value: url };
     }
 
     core.debug(
@@ -229,7 +229,7 @@ export async function fetchWorkflowRunActiveJobUrlRetry(
   }
   core.debug(`Timed out while trying to fetch URL for Workflow Run ${runId}`);
 
-  return "Unable to fetch URL";
+  return { success: false, reason: "timeout" };
 }
 
 export async function retryOnError<T>(

src/main.ts

@@ -13,33 +13,39 @@ async function main(): Promise<void> {
     const config = getConfig();
     api.init(config);
 
-    const activeJobUrl = await api.fetchWorkflowRunActiveJobUrlRetry(
+    const activeJobUrlResult = await api.fetchWorkflowRunActiveJobUrlRetry(
       config.runId,
       constants.WORKFLOW_RUN_ACTIVE_JOB_TIMEOUT_MS,
     );
+    if (!activeJobUrlResult.success) {
+      const elapsedTime = Date.now() - startTime;
+      const failureMsg = `Timeout exceeded while attempting to find the active job run URL (${elapsedTime}ms)`;
+      await handleActionFail(failureMsg, config.runId);
+      return;
+    }
     core.info(
       `Awaiting completion of Workflow Run ${config.runId}...\n` +
         `  ID: ${config.runId}\n` +
-        `  URL: ${activeJobUrl}`,
+        `  URL: ${activeJobUrlResult.value}`,
     );
 
-    const result = await getWorkflowRunResult({
+    const runResult = await getWorkflowRunResult({
       startTime,
       pollIntervalMs: config.pollIntervalMs,
       runId: config.runId,
       runTimeoutMs: config.runTimeoutSeconds * 1000,
     });
-    if (!result.success) {
+    if (!runResult.success) {
       const elapsedTime = Date.now() - startTime;
       const failureMsg =
-        result.reason === "timeout"
+        runResult.reason === "timeout"
           ? `Timeout exceeded while attempting to await run conclusion (${elapsedTime}ms)`
-          : `An unsupported value was reached: ${result.value}`;
+          : `An unsupported value was reached: ${runResult.value}`;
       await handleActionFail(failureMsg, config.runId);
       return;
     }
 
-    const { status, conclusion } = result.value;
+    const { status, conclusion } = runResult.value;
     if (conclusion === WorkflowRunConclusion.Success) {
       core.info(
         "Run Completed:\n" +