refactor: use dot access instead of index key for mock types

Author: Codex-

src/action.spec.ts

@@ -134,7 +134,7 @@ describe("Action", () => {
     });
 
     it("should handle no distinct_id being provided", () => {
-      const v4Mock = v4 as unknown as MockInstance<typeof v4>;
+      const v4Mock = vi.mocked(v4);
       v4Mock.mockImplementationOnce(() => "test-uuid-is-used");
       mockEnvConfig.distinct_id = "";
       const config: ActionConfig = getConfig();

src/api.ts

@@ -5,7 +5,7 @@ import { type ActionConfig, getConfig } from "./action.ts";
 import type { Result } from "./types.ts";
 import { sleep, type BranchNameResult } from "./utils.ts";
 
-type Octokit = ReturnType<(typeof github)["getOctokit"]>;
+type Octokit = ReturnType<typeof github.getOctokit>;
 
 let config: ActionConfig;
 let octokit: Octokit;

src/main.spec.ts

@@ -43,33 +43,31 @@ describe("main", () => {
   };
 
   // Core
-  let coreSetFailedMock: MockInstance<(typeof core)["setFailed"]>;
+  let coreSetFailedMock: MockInstance<typeof core.setFailed>;
 
   // Action
-  let actionGetConfigMock: MockInstance<(typeof action)["getConfig"]>;
+  let actionGetConfigMock: MockInstance<typeof action.getConfig>;
 
   // API
-  let apiDispatchWorkflowMock: MockInstance<(typeof api)["dispatchWorkflow"]>;
-  let apiInitMock: MockInstance<(typeof api)["init"]>;
+  let apiDispatchWorkflowMock: MockInstance<typeof api.dispatchWorkflow>;
+  let apiInitMock: MockInstance<typeof api.init>;
 
   // Utils
-  let utilsGetBranchNameMock: MockInstance<(typeof utils)["getBranchName"]>;
+  let utilsGetBranchNameMock: MockInstance<typeof utils.getBranchName>;
   let utilsLogInfoForBranchNameResult: MockInstance<
-    (typeof utils)["logInfoForBranchNameResult"]
+    typeof utils.logInfoForBranchNameResult
   >;
 
   // Return Dispatch
-  let returnDispatchGetRunIdMock: MockInstance<
-    (typeof returnDispatch)["getRunId"]
-  >;
+  let returnDispatchGetRunIdMock: MockInstance<typeof returnDispatch.getRunId>;
   let returnDispatchGetWorkflowIdMock: MockInstance<
-    (typeof returnDispatch)["getWorkflowId"]
+    typeof returnDispatch.getWorkflowId
   >;
   let returnDispatchHandleFailMock: MockInstance<
-    (typeof returnDispatch)["handleActionFail"]
+    typeof returnDispatch.handleActionFail
   >;
   let returnDispatchHandleSuccessMock: MockInstance<
-    (typeof returnDispatch)["handleActionSuccess"]
+    typeof returnDispatch.handleActionSuccess
   >;
 
   afterAll(() => {

src/return-dispatch.spec.ts

@@ -45,7 +45,7 @@ describe("return-dispatch", () => {
   });
 
   describe("fetchWorkflowId", () => {
-    let fetchWorkflowIdMock: MockInstance<(typeof api)["fetchWorkflowId"]>;
+    let fetchWorkflowIdMock: MockInstance<typeof api.fetchWorkflowId>;
 
     beforeAll(() => {
       fetchWorkflowIdMock = vi.spyOn(api, "fetchWorkflowId");
@@ -380,8 +380,8 @@ describe("return-dispatch", () => {
   });
 
   describe("handleAction", () => {
-    let setFailedSpy: MockInstance<(typeof core)["setFailed"]>;
-    let setOutputSpy: MockInstance<(typeof core)["setOutput"]>;
+    let setFailedSpy: MockInstance<typeof core.setFailed>;
+    let setOutputSpy: MockInstance<typeof core.setOutput>;
 
     beforeEach(() => {
       setFailedSpy = vi.spyOn(core, "setFailed");

src/test-utils/logging.mock.ts

@@ -16,13 +16,13 @@ interface MockedLoggingFunctions {
 }
 
 export function mockLoggingFunctions(): MockedLoggingFunctions {
-  const coreDebugLogMock: MockInstance<(typeof core)["debug"]> = vi
+  const coreDebugLogMock: MockInstance<typeof core.debug> = vi
     .spyOn(core, "debug")
     .mockImplementation(() => undefined);
-  const coreInfoLogMock: MockInstance<(typeof core)["info"]> = vi
+  const coreInfoLogMock: MockInstance<typeof core.info> = vi
     .spyOn(core, "info")
     .mockImplementation(() => undefined);
-  const coreErrorLogMock: MockInstance<(typeof core)["error"]> = vi
+  const coreErrorLogMock: MockInstance<typeof core.error> = vi
     .spyOn(core, "error")
     .mockImplementation(() => undefined);