Skip to content

Commit 4a4a7ce

Browse files
committed
cleanup(sdk): simpler implementation of deps
1 parent 8cad83b commit 4a4a7ce

File tree

1 file changed

+3
-6
lines changed
  • engine/core/src/main/resources/view/core

1 file changed

+3
-6
lines changed

engine/core/src/main/resources/view/core/Drawer.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,15 +92,12 @@ export class Drawer {
9292

9393
instantiateModules () {
9494
this.modules = {}
95-
96-
const moduleNames = config.modules.map(Module => Module.moduleName ?? Module.name)
97-
9895

99-
config.modules.forEach((Module, idx) => {
96+
for (const Module of config.modules) {
10097
try {
10198
const dependencies = Module.dependencies ?? []
10299
for (let dep of dependencies) {
103-
if (!moduleNames.slice(0, idx).includes(dep)) {
100+
if (this.modules[dep] == null) {
104101
throw new Error(`Required module "${dep}" not yet loaded. Make sure it comes first in your config.js "modules" array`)
105102
}
106103
}
@@ -109,7 +106,7 @@ export class Drawer {
109106
} catch (error) {
110107
this.handleModuleError(Module.moduleName ?? Module.name, error)
111108
}
112-
})
109+
}
113110
}
114111

115112
destroy () {

0 commit comments

Comments
 (0)