Skip to content

Commit 4e8e05b

Browse files
Merge branch 'fix-player-error-firefox' into 'master'
fix(sdk): properly display errors on Firefox See merge request codingame/game-engine!238
2 parents 49ee2e0 + afbec4d commit 4e8e05b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

runner/src/main/resources/view/app.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,11 @@ function PlayerCtrl ($scope, $timeout, $interval, $element) {
4747
function addError (error) {
4848
let errorText = error.message + '\n'
4949
if (error.cause) {
50-
errorText += error.cause + '\n'
50+
if (typeof error.cause === 'string') {
51+
errorText += error.cause + '\n'
52+
} else {
53+
errorText += error.cause.message + '\n'
54+
}
5155
}
5256
if (!$scope.errors[errorText]) {
5357
$scope.errors[errorText] = { quantity: 1 }

runner/src/main/resources/view/player.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)