@@ -126,7 +126,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $element) {
126126 }
127127
128128 function onFrameChange ( frame ) {
129- // one frame in this method is one game turn, and contians subframes for each agent's actions
129+ // one frame in this method is one game turn, and contains subframes for each agent's actions
130130 for ( let i in ctrl . data . ids ) {
131131 $scope . agents [ i ] . stdout = null
132132 $scope . agents [ i ] . stderr = null
@@ -135,14 +135,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $element) {
135135 $scope . referee = { }
136136 const frameData = ctrl . parsedGameInfo . frames [ frame ]
137137 for ( let i in ctrl . data . ids ) {
138- let subframe
139- if ( frameData . subframes . length > 1 ) {
140- subframe = frameData . subframes [ i ]
141- } else {
142- if ( frameData . subframes [ 0 ] . agentId === i ) {
143- subframe = frameData . subframes [ 0 ]
144- }
145- }
138+ const subframe = frameData . subframes . find ( subframe => subframe . agentId === i )
146139 if ( subframe ) {
147140 if ( subframe . stdout ) {
148141 $scope . agents [ i ] . stdout = subframe . stdout
@@ -186,6 +179,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $element) {
186179 // check that at turn i, agent has output not null, so it is agent's turn
187180 if ( output [ i ] != null && agentId !== 'referee' ) {
188181 frames [ i ] . agentId = agentId
182+ break
189183 }
190184 }
191185 }
0 commit comments