Merge branch '6686-cgcontribution-uncaught-exception-when-trying-to-parse-an-incorrect-json-maybe-spritesheet' into 'master'

6686 cgcontribution uncaught exception when trying to parse an incorrect json maybe spritesheet

See merge request codingame/game-engine!249

Author: CodinGameCommunity

playground/misc/misc-3-release-notes.md

@@ -2,6 +2,12 @@
 
 The CodinGame SDK is regularly updated and improved. This document lets you know what changed in the latest releases.
 
+## NEXT RELEASE
+
+### 🐞 Bug fix
+
+- Fixed crashes when invalid JSON files are in assets folder
+
 ## 3.9.0
 
 ### 🎁 Features

runner/src/main/java/com/codingame/gameengine/runner/Renderer.java

@@ -258,7 +258,7 @@ private static void generateAssetsFile(Path tmpdir, String assetsPath) {
                                     if (!fonts.contains(new JsonPrimitive(newName))) {
                                         fonts.add(newName);
                                     }
-                                    
+
                                     Files.write(
                                         tmpdir.resolve("hashed_assets").resolve(newName),
                                         newContent.getBytes(),
@@ -284,6 +284,9 @@ private static void generateAssetsFile(Path tmpdir, String assetsPath) {
                                     );
                                 }
                             }
+                        } catch (JsonSyntaxException e) {
+                            log.error("Invalid JSON in file " + f.getFileName() + " at " + f.toString().replaceAll("^" + tmpdir.toString(), ""));
+                            e.printStackTrace();
                         } catch (IOException e) {
                             e.printStackTrace();
                         }
@@ -526,8 +529,8 @@ private void checkQuestionsTypeValidity(GameConfig gameConfig, QuestionConfig qu
                 throw new MissingConfigException("An optimization game must have a sorting_order property in config.ini.");
             } else if (!"ASC".equalsIgnoreCase(questionConfig.getSortingOrder())
                 && !"DESC".equalsIgnoreCase(questionConfig.getSortingOrder())) {
-                throw new MissingConfigException("The sorting order for an optimization game must be ASC (ascendant) or DESC (descendant)");
-            }
+                    throw new MissingConfigException("The sorting order for an optimization game must be ASC (ascendant) or DESC (descendant)");
+                }
         }
 
         switch (gameConfig.getGameType()) {
@@ -679,7 +682,8 @@ public void handleRequest(HttpServerExchange exchange) throws Exception {
                                             }
 
                                             exchange.setStatusCode(StatusCodes.OK);
-                                        } if (exchange.getRelativePath().equals("/stub")) {
+                                        }
+                                        if (exchange.getRelativePath().equals("/stub")) {
                                             File stubFile = sourceFolderPath.resolve("config/stub.txt").toFile();
                                             if (exchange.getRequestMethod().equalToString("GET")) {
                                                 String stub = FileUtils.readFileToString(stubFile, StandardCharsets.UTF_8);