refactor(viewport): simplify frame data

Valentin Vetter · Valentin Vetter · commit 91b8ff427325 · 2019-09-19T12:08:49.000+02:00
diff --git a/engine/modules/viewport/src/main/java/com/codingame/gameengine/module/viewport/ViewportModule.java b/engine/modules/viewport/src/main/java/com/codingame/gameengine/module/viewport/ViewportModule.java
@@ -46,9 +46,7 @@ public void onAfterOnEnd() {
     }
 
     private void sendFrameData() {
-        Object[] data = { newEntityIds };
-
-        gameManager.setViewData("viewport", data);
+        gameManager.setViewData("viewport", newEntityIds);
 
         newEntityIds.clear();
     }
diff --git a/engine/modules/viewport/src/main/resources/view/viewport-module/ViewportModule.js b/engine/modules/viewport/src/main/resources/view/viewport-module/ViewportModule.js
@@ -19,7 +19,7 @@ export class ViewportModule {
    */
   handleFrameData (frameInfo, frameData) {
     // Handle your data here
-    const [newEntityIds] = frameData
+    const newEntityIds = frameData
 
     this.entityIds = [...this.entityIds, ...newEntityIds]
 

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,7 @@ public void onAfterOnEnd() {`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`private void sendFrameData() {`
`49`		`- Object[] data = { newEntityIds };`
`50`		`-`
`51`		`- gameManager.setViewData("viewport", data);`
	`49`	`+ gameManager.setViewData("viewport", newEntityIds);`
`52`	`50`
`53`	`51`	`newEntityIds.clear();`
`54`	`52`	`}`