Skip to content

Commit b7439ea

Browse files
author
Julien Poulton
committed
Merge branch 'zip-slip' into 'master'
Fix ZipSlip bug found by LGTM.com See merge request codingame/game-engine!142
2 parents 4658f29 + 1e50f76 commit b7439ea

File tree

1 file changed

+3
-0
lines changed
  • runner/src/main/java/com/codingame/gameengine/runner

1 file changed

+3
-0
lines changed

runner/src/main/java/com/codingame/gameengine/runner/Renderer.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,9 @@ private static List<Path> exportViewToWorkingDir(String sourceFolder, Path targe
139139
String entryTail = name.substring(sourceFolder.length());
140140

141141
File f = new File(targetFolder + File.separator + entryTail);
142+
if (!f.toPath().normalize().startsWith(targetFolder)) {
143+
throw new IOException("Zip entry contained path traversal");
144+
}
142145
if (entry.isDirectory()) {
143146
f.mkdir();
144147
} else {

0 commit comments

Comments
 (0)