Merge branch 'fix-worldcommits-showing-entities-they-shouldnt' into 'master'

[FIX][sdk] fix wolrdcommits showing entities they shouldn't

See merge request codingame/game-engine!132

Author: Builder

engine/modules/entities/src/main/java/com/codingame/gameengine/module/entities/Entity.java

@@ -17,7 +17,7 @@ public abstract class Entity<T extends Entity<?>> {
 
     private int x, y, zIndex;
     private double scaleX = 1, scaleY = 1;
-    private boolean visible = true;
+    private boolean visible = false;
     private double rotation, alpha = 1;
     ContainerBasedEntity parent;
     Mask mask;
@@ -29,7 +29,12 @@ static enum Type {
     Entity() {
         id = ++GraphicEntityModule.ENTITY_COUNT;
         state = new EntityState();
-
+        
+        // World commits made before the creation of an entity should not affect that entity.
+        // This is why we set `visible` to false by default and immediately setVisible(true),
+        // this way the first commit of this entity will turn it into something visible.
+        // All other properties have no impact while the entity is invisible so it is effectively non-existant until it's first commit.
+        setVisible(true);
     }
 
     @SuppressWarnings("unchecked")

engine/modules/entities/src/main/resources/view/entity-module/Entity.js

@@ -13,7 +13,7 @@ export class Entity {
       scaleY: 1,
       zIndex: 0,
       alpha: 1,
-      visible: true,
+      visible: false,
       rotation: 0,
       mask: -1
     }