fix(sdk): Removed empty error console in the view intro replay popup

Author: Julien

runner/src/main/resources/view/app.js

@@ -1,6 +1,6 @@
 import * as config from '../config.js'
-import {ErrorLog} from '../core/ErrorLog.js'
-import {demo as defaultDemo} from '../demo.js'
+import { ErrorLog } from '../core/ErrorLog.js'
+import { demo as defaultDemo } from '../demo.js'
 import Parser from './lib/Parser.js'
 import './player.js'
 
@@ -38,6 +38,10 @@ function PlayerCtrl ($scope, $timeout, $interval, $filter, $element) {
 
   $interval(checkSize, 1000)
 
+  $scope.isEmptyObject = function (obj) {
+    return angular.equals(obj, {})
+  }
+
   $scope.errors = {}
   ErrorLog.listen(function (error) {
     addError(error)
@@ -49,7 +53,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $filter, $element) {
       errorText += error.cause + '\n'
     }
     if (!$scope.errors[errorText]) {
-      $scope.errors[errorText] = {quantity: 1}
+      $scope.errors[errorText] = { quantity: 1 }
     } else {
       $scope.errors[errorText].quantity += 1
     }
@@ -101,7 +105,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $filter, $element) {
     $scope.gameLoaded = true
     $scope.uinput = ctrl.data.uinput
     ctrl.gameInfo = convertFrameFormat(ctrl.data)
-    $scope.agents = {...ctrl.data.agents}
+    $scope.agents = { ...ctrl.data.agents }
 
     cgPlayer.sendFrames(ctrl.gameInfo)
     cgPlayer.subscribe(onUpdate)
@@ -151,7 +155,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $filter, $element) {
       let f = v.split('\n')
       let header = f[0].split(' ')
 
-      return {view: v.replace(/^(KEY_FRAME)|(INTERMEDIATE_FRAME)/, ''), keyframe: header[0] === 'KEY_FRAME'}
+      return { view: v.replace(/^(KEY_FRAME)|(INTERMEDIATE_FRAME)/, ''), keyframe: header[0] === 'KEY_FRAME' }
     })
     for (let i = 0; i < frames.length; i++) {
       frames[i].gameSummary = data.summaries[i]
@@ -161,9 +165,9 @@ function PlayerCtrl ($scope, $timeout, $interval, $filter, $element) {
       }
       frames[i].agentId = -1
     }
-    const agents = data.agents.map(a => Object.assign(a, {avatarUrl: a.avatar}))
+    const agents = data.agents.map(a => Object.assign(a, { avatarUrl: a.avatar }))
     const tooltips = data.tooltips.map(JSON.stringify)
-    return {agents: agents, frames: frames, tooltips: tooltips}
+    return { agents: agents, frames: frames, tooltips: tooltips }
   }
 
   function checkSize () {

runner/src/main/resources/view/test.html

@@ -45,8 +45,8 @@
 		<div ng-show="showViewReplayPopup" class="report-popup-wrapper">
 			<div class="viewer-popup">	
 				<div class="cg-player-sandbox-replay"></div>
-				<div id="console" class="outputs-demo">
-					<div class="output-log" ng-repeat="(key,value) in errors" ng-if="errors">
+				<div id="console" class="outputs-demo" ng-if="!isEmptyObject(errors)">
+					<div class="output-log" ng-repeat="(key,value) in errors">
 						<span class="collapsed-bubble" ng-if="value.quantity > 1">
 							<span class="collapsed-count"
 								ng-bind="value.quantity"