Merge branch 'fix-spriteanimation' into 'master'

[FIX] fix animation when duration is changed

See merge request codingame/game-engine!244

Author: CodinGameCommunity

engine/modules/entities/src/main/resources/view/entity-module/SpriteAnimation.js

@@ -14,7 +14,7 @@ export class SpriteAnimation extends TextureBasedEntity {
       duration: 1000,
       playing: true,
       restarted: null,
-      animationProgressTime: 0,
+      animationProgress: 0,
       date: 0
     })
   }
@@ -35,12 +35,10 @@ export class SpriteAnimation extends TextureBasedEntity {
     super.updateDisplay(state, changed, globalData)
 
     if (state.images) {
-      const duration = state.duration
       const images = state.images.split(',')
 
-      const animationProgress = (state.loop ? unlerpUnclamped : unlerp)(0, duration, state.animationProgressTime)
-      if (animationProgress >= 0) {
-        const animationIndex = Math.floor(images.length * animationProgress)
+      if (state.animationProgress >= 0) {
+        const animationIndex = Math.floor(images.length * state.animationProgress)
         const image = state.loop ? images[animationIndex % images.length] : (images[animationIndex] || images[images.length - 1])
         try {
           this.graphics.texture = PIXI.Texture.fromFrame(image)
@@ -55,11 +53,11 @@ export class SpriteAnimation extends TextureBasedEntity {
 
   computeAnimationProgressTime (prevState, currState) {
     if (currState.restarted && currState.restarted.date === currState.date) {
-      currState.animationProgressTime = 0
+      currState.animationProgress = 0
     } else {
-      currState.animationProgressTime = prevState.animationProgressTime
+      currState.animationProgress = prevState.animationProgress
       if (prevState.playing) {
-        currState.animationProgressTime += currState.date - prevState.date
+        currState.animationProgress += (currState.date - prevState.date) / prevState.duration
       }
     }
   }

playground/misc/misc-3-release-notes.md

@@ -2,6 +2,12 @@
 
 The CodinGame SDK is regularly updated and improved. This document lets you know what changed in the latest releases.
 
+## 3.8.3
+
+### 🐞 Bug fix
+
+- SpriteAnimation: fix wrong current frame when the animation duration is changed
+
 ## 3.8.2
 
 ### 🐞 Bug fix