Skip to content

Commit 4adea08

Browse files
author
Loïc Mangeonjean
committed
fix: fix model not created if the language doesn't change
1 parent a341d8b commit 4adea08

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/MonacoEditor.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,12 @@ function MonacoEditor ({
147147
const lastSaveViewState = useLastVersion(saveViewState)
148148
const lastRestoreViewState = useLastVersion(restoreViewState)
149149

150+
const hasValue = fixedCode != null
151+
150152
// Create/Update model
151153
useEffect(() => {
152-
const value = valueRef.current
153-
if (modelUri != null || value != null) {
154+
if (modelUri != null || hasValue) {
155+
const value = valueRef.current
154156
const existingModel = modelUri != null ? monaco.editor.getModel(modelUri) : null
155157
const model = existingModel ?? monaco.editor.createModel(value!, monacoLanguage, modelUri)
156158
if (monacoLanguage != null && model.getLanguageId() !== monacoLanguage) {
@@ -176,7 +178,7 @@ function MonacoEditor ({
176178
editorRef.current?.setModel(null)
177179
}
178180
return undefined
179-
}, [monacoLanguage, modelUri, valueRef, lastSaveViewState, lastRestoreViewState, disposeModels])
181+
}, [monacoLanguage, modelUri, valueRef, lastSaveViewState, lastRestoreViewState, disposeModels, hasValue])
180182

181183
// Create editor
182184
useEffect(() => {

0 commit comments

Comments
 (0)