Merge pull request #49 from CodinGame/fix-model-change

CGNonofr · web-flow · commit d1a4104acc96 · 2024-04-23T09:59:18.000+02:00
Fix model update
diff --git a/src/MonacoEditor.tsx b/src/MonacoEditor.tsx
@@ -215,12 +215,11 @@ function MonacoEditor ({
       if (fileUri != null) {
         const uri = monaco.Uri.parse(fileUri)
 
-        const fileDisposable = registerFile(new RegisteredMemoryFile(uri, value!))
+        disposableStore.add(registerFile(new RegisteredMemoryFile(uri, value!)))
 
         const modelIRefPromise = createModelReference(uri)
         disposableStore.add({
           dispose () {
-            fileDisposable.dispose()
             void modelIRefPromise.then(modelIRef => modelIRef.dispose(), console.error)
           }
         })
@@ -249,7 +248,6 @@ function MonacoEditor ({
           lastSaveViewState(editorRef.current, model)
         }
         disposableStore.dispose()
-        modelRef.current = undefined
       }
     }
     const disposePromise = updateModel()

Original file line number	Diff line number	Diff line change
`@@ -215,12 +215,11 @@ function MonacoEditor ({`
`215`	`215`	`if (fileUri != null) {`
`216`	`216`	`const uri = monaco.Uri.parse(fileUri)`
`217`	`217`
`218`		`- const fileDisposable = registerFile(new RegisteredMemoryFile(uri, value!))`
	`218`	`+ disposableStore.add(registerFile(new RegisteredMemoryFile(uri, value!)))`
`219`	`219`
`220`	`220`	`const modelIRefPromise = createModelReference(uri)`
`221`	`221`	`disposableStore.add({`
`222`	`222`	`dispose () {`
`223`		`- fileDisposable.dispose()`
`224`	`223`	`void modelIRefPromise.then(modelIRef => modelIRef.dispose(), console.error)`
`225`	`224`	`}`
`226`	`225`	`})`
`@@ -249,7 +248,6 @@ function MonacoEditor ({`
`249`	`248`	`lastSaveViewState(editorRef.current, model)`
`250`	`249`	`}`
`251`	`250`	`disposableStore.dispose()`
`252`		`- modelRef.current = undefined`
`253`	`251`	`}`
`254`	`252`	`}`
`255`	`253`	`const disposePromise = updateModel()`