refactor: Load file configuration no matter what

Author: CGNonofr

src/configuration/files.ts

@@ -0,0 +1,57 @@
+import * as monaco from 'monaco-editor'
+const configurationRegistry = monaco.extra.Registry.as<monaco.extra.IConfigurationRegistry>(monaco.extra.ConfigurationExtensions.Configuration)
+
+/**
+ * comes from https://github.com/microsoft/vscode/blob/16d0a319b28caa4b6cf4e6801fd508282b7533e0/src/vs/workbench/contrib/files/browser/files.contribution.ts#L132
+ * Required by the Lua language server
+ */
+export const FILES_EXCLUDE_CONFIG = 'files.exclude'
+export const FILES_ASSOCIATIONS_CONFIG = 'files.associations'
+const isWeb = true
+const ConfigurationScope = monaco.extra.ConfigurationScope
+const nls = {
+  localize: (key: string, defaultValue: string) => defaultValue
+}
+configurationRegistry.registerConfiguration({
+  id: 'files',
+  order: 9,
+  title: 'Files',
+  type: 'object',
+  properties: {
+    [FILES_EXCLUDE_CONFIG]: {
+      type: 'object',
+      markdownDescription: nls.localize('exclude', 'Configure glob patterns for excluding files and folders. For example, the file Explorer decides which files and folders to show or hide based on this setting. Refer to the `#search.exclude#` setting to define search specific excludes. Read more about glob patterns [here](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options).'),
+      default: {
+        ...{ '**/.git': true, '**/.svn': true, '**/.hg': true, '**/CVS': true, '**/.DS_Store': true, '**/Thumbs.db': true },
+        ...(isWeb as boolean ? { '**/*.crswap': true /* filter out swap files used for local file access */ } : undefined)
+      },
+      scope: ConfigurationScope.RESOURCE,
+      additionalProperties: {
+        anyOf: [
+          {
+            type: 'boolean',
+            description: nls.localize('files.exclude.boolean', 'The glob pattern to match file paths against. Set to true or false to enable or disable the pattern.')
+          },
+          {
+            type: 'object',
+            properties: {
+              when: {
+                type: 'string', // expression ({ "**/*.js": { "when": "$(basename).js" } })
+                pattern: '\\w*\\$\\(basename\\)\\w*',
+                default: '$(basename).ext',
+                description: nls.localize('files.exclude.when', 'Additional check on the siblings of a matching file. Use $(basename) as variable for the matching file name.')
+              }
+            }
+          }
+        ]
+      }
+    },
+    [FILES_ASSOCIATIONS_CONFIG]: {
+      type: 'object',
+      markdownDescription: nls.localize('associations', 'Configure file associations to languages (e.g. `"*.extension": "html"`). These have precedence over the default associations of the languages installed.'),
+      additionalProperties: {
+        type: 'string'
+      }
+    }
+  }
+})

src/configuration/index.ts

@@ -3,6 +3,7 @@ import { IConfigurationChangeEvent, IConfigurationService } from 'vscode/service
 import * as vscode from 'vscode'
 import { updateUserConfiguration } from 'vscode/service-override/configuration'
 import extensions from '../languages/extensions/extensions.json'
+import './files'
 
 const configurationRegistry = monaco.extra.Registry.as<monaco.extra.IConfigurationRegistry>(monaco.extra.ConfigurationExtensions.Configuration)
 configurationRegistry.registerDefaultConfigurations([{

src/features/extensionConfigurations.ts

@@ -11,58 +11,3 @@ export async function loadConfigurationForExtension (extensionId: string): Promi
   const configuration = await loader()
   configurationRegistry.registerConfigurations(configuration)
 }
-
-/**
- * comes from https://github.com/microsoft/vscode/blob/16d0a319b28caa4b6cf4e6801fd508282b7533e0/src/vs/workbench/contrib/files/browser/files.contribution.ts#L132
- * Required by the Lua language server
- */
-export const FILES_EXCLUDE_CONFIG = 'files.exclude'
-export const FILES_ASSOCIATIONS_CONFIG = 'files.associations'
-const isWeb = true
-const ConfigurationScope = monaco.extra.ConfigurationScope
-const nls = {
-  localize: (key: string, defaultValue: string) => defaultValue
-}
-configurationRegistry.registerConfiguration({
-  id: 'files',
-  order: 9,
-  title: 'Files',
-  type: 'object',
-  properties: {
-    [FILES_EXCLUDE_CONFIG]: {
-      type: 'object',
-      markdownDescription: nls.localize('exclude', 'Configure glob patterns for excluding files and folders. For example, the file Explorer decides which files and folders to show or hide based on this setting. Refer to the `#search.exclude#` setting to define search specific excludes. Read more about glob patterns [here](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options).'),
-      default: {
-        ...{ '**/.git': true, '**/.svn': true, '**/.hg': true, '**/CVS': true, '**/.DS_Store': true, '**/Thumbs.db': true },
-        ...(isWeb as boolean ? { '**/*.crswap': true /* filter out swap files used for local file access */ } : undefined)
-      },
-      scope: ConfigurationScope.RESOURCE,
-      additionalProperties: {
-        anyOf: [
-          {
-            type: 'boolean',
-            description: nls.localize('files.exclude.boolean', 'The glob pattern to match file paths against. Set to true or false to enable or disable the pattern.')
-          },
-          {
-            type: 'object',
-            properties: {
-              when: {
-                type: 'string', // expression ({ "**/*.js": { "when": "$(basename).js" } })
-                pattern: '\\w*\\$\\(basename\\)\\w*',
-                default: '$(basename).ext',
-                description: nls.localize('files.exclude.when', 'Additional check on the siblings of a matching file. Use $(basename) as variable for the matching file name.')
-              }
-            }
-          }
-        ]
-      }
-    },
-    [FILES_ASSOCIATIONS_CONFIG]: {
-      type: 'object',
-      markdownDescription: nls.localize('associations', 'Configure file associations to languages (e.g. `"*.extension": "html"`). These have precedence over the default associations of the languages installed.'),
-      additionalProperties: {
-        type: 'string'
-      }
-    }
-  }
-})