Skip to content

Commit 8e01bf3

Browse files
author
Loïc Mangeonjean
committed
refactor: resolve externals using resolveId function
1 parent af8a927 commit 8e01bf3

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

rollup.config.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,6 @@ export default rollup.defineConfig({
2626
'features/notifications': 'src/features/notifications.ts',
2727
'features/extensionGallery': 'src/features/extensionGallery.ts'
2828
},
29-
external: function isExternal (source, importer, isResolved) {
30-
if (isResolved) {
31-
return false
32-
}
33-
if (/\.wasm$/.test(source)) {
34-
return true
35-
}
36-
return externals.some(external => source === external || source.startsWith(`${external}/`))
37-
},
3829
output: [{
3930
dir: 'dist',
4031
format: 'esm',
@@ -49,6 +40,18 @@ export default rollup.defineConfig({
4940
}],
5041
plugins: [
5142
builtins(),
43+
{
44+
name: 'external-resolver',
45+
resolveId (id) {
46+
if (/\.wasm$/.test(id) || externals.some(external => id === external || id.startsWith(`${external}/`))) {
47+
return {
48+
id,
49+
external: true
50+
}
51+
}
52+
return undefined
53+
}
54+
},
5255
{
5356
name: 'glob-vsix-import',
5457
async resolveId (source, importer) {

0 commit comments

Comments
 (0)