Skip to content

Commit cfd4ad1

Browse files
committed
fix: The parameter can be null (typescript failure)
1 parent 49b81d8 commit cfd4ad1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/services/MultiEditorStandaloneCodeEditorService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function openNewCodeEditor (model: monaco.editor.ITextModel) {
5454
return editor
5555
}
5656

57-
export type EditorOpenHandler = (model: monaco.editor.ITextModel, input: monaco.extra.IResourceEditorInput, editor: monaco.editor.ICodeEditor, sideBySide?: boolean) => Promise<monaco.editor.ICodeEditor | null>
57+
export type EditorOpenHandler = (model: monaco.editor.ITextModel, input: monaco.extra.IResourceEditorInput, editor: monaco.editor.ICodeEditor | null, sideBySide?: boolean) => Promise<monaco.editor.ICodeEditor | null>
5858

5959
export default class MultiEditorStandaloneCodeEditorServiceImpl extends monaco.extra.StandaloneCodeEditorService {
6060
private textModelService: monaco.extra.ITextModelService
@@ -81,11 +81,11 @@ export default class MultiEditorStandaloneCodeEditorServiceImpl extends monaco.e
8181
}
8282
}
8383

84-
override async openCodeEditor (input: monaco.extra.IResourceEditorInput, editor: monaco.editor.ICodeEditor, sideBySide?: boolean): Promise<monaco.editor.ICodeEditor | null> {
84+
override async openCodeEditor (input: monaco.extra.IResourceEditorInput, editor: monaco.editor.ICodeEditor | null, sideBySide?: boolean): Promise<monaco.editor.ICodeEditor | null> {
8585
const reference = await this.textModelService.createModelReference(input.resource)
8686
const model = reference.object.textEditorModel
8787
let modelEditor: monaco.editor.ICodeEditor | undefined
88-
if (editor.getModel() === model) {
88+
if (editor != null && editor.getModel() === model) {
8989
modelEditor = editor
9090
}
9191
if (modelEditor == null) {

0 commit comments

Comments
 (0)