refactor: Move java specific code to java feature

Author: CGNonofr

src/extensions/java.ts

@@ -0,0 +1,33 @@
+import {
+  DisposableCollection, MonacoLanguageClient
+} from 'monaco-languageclient'
+import { StaticFeature, FeatureState } from 'vscode-languageclient/lib/common/api'
+import { WorkspaceEdit } from 'vscode-languageserver-protocol'
+import * as vscode from 'vscode'
+
+export class JavaExtensionFeature implements StaticFeature {
+  private disposables: DisposableCollection
+  constructor (private languageClient: MonacoLanguageClient) {
+    this.disposables = new DisposableCollection()
+  }
+
+  fillClientCapabilities (): void {}
+
+  initialize (): void {
+    // Comes from https://github.com/redhat-developer/vscode-java/blob/9b6046eecc65fd47507f309a3ccc9add45c6d3be/src/standardLanguageClient.ts#L321
+    this.disposables.push(vscode.commands.registerCommand('java.apply.workspaceEdit', async (obj: WorkspaceEdit) => {
+      const edit = await this.languageClient.protocol2CodeConverter.asWorkspaceEdit(obj)
+      return vscode.workspace.applyEdit(edit)
+    }))
+  }
+
+  getState (): FeatureState {
+    return {
+      kind: 'static'
+    }
+  }
+
+  dispose (): void {
+    this.disposables.dispose()
+  }
+}

src/services.ts

@@ -1,8 +1,5 @@
 
 import { Services } from 'vscode/services'
-import { WorkspaceEdit, Disposable } from 'vscode-languageserver-protocol'
-import * as vscode from 'vscode'
-import { createConverter as createProtocolConverter } from 'vscode-languageclient/lib/common/protocolConverter'
 import WatchableConsoleWindow from './services/WatchableConsoleWindow'
 import CodinGameMonacoWorkspace from './services/CodinGameMonacoWorkspace'
 import { Infrastructure } from './infrastructure'
@@ -13,25 +10,13 @@ interface CgMonacoServices extends Services {
   window: WatchableConsoleWindow
 }
 
-function installCommands (): Disposable {
-  // Comes from https://github.com/redhat-developer/vscode-java/blob/9b0f0aca80cbefabad4c034fb5dd365d029f6170/src/extension.ts#L155-L160
-  // Other commands needs to be implemented as well?
-  // (https://github.com/eclipse/eclipse.jdt.ls/issues/376#issuecomment-333923685)
-  const protocolConverter = createProtocolConverter(undefined, true, true)
-  return vscode.commands.registerCommand('java.apply.workspaceEdit', async (obj: WorkspaceEdit) => {
-    const edit = await protocolConverter.asWorkspaceEdit(obj)
-    return vscode.workspace.applyEdit(edit)
-  })
-}
-
 const services = {
   workspace: new CodinGameMonacoWorkspace('file:///tmp/project'),
   window: new WatchableConsoleWindow(),
   env: new CodinGameMonacoEnv()
 }
 
 Services.install(services)
-installCommands()
 
 function updateServices (infrastructure: Infrastructure): void {
   services.workspace.initialize(

src/staticOptions.ts

@@ -2,6 +2,7 @@ import * as vscode from 'vscode'
 import * as monaco from 'monaco-editor'
 import type { LanguageClientOptions } from './languageClientOptions'
 import { CobolResolveSubroutineFeature } from './extensions/cobol'
+import { JavaExtensionFeature } from './extensions/java'
 
 type LanguageClientOptionsById<T extends string> = Record<T, LanguageClientOptions>
 const asLanguageClientOptionsById = <K extends string> (options: LanguageClientOptionsById<K>): LanguageClientOptionsById<K> => options
@@ -117,7 +118,12 @@ const staticOptions = asLanguageClientOptionsById({
       configurationSection: ['java', 'editor.insertSpaces', 'editor.tabSize']
     },
     mutualizable: true,
-    vscodeExtensionIds: ['java']
+    vscodeExtensionIds: ['java'],
+    createAdditionalFeatures (client) {
+      return [
+        new JavaExtensionFeature(client)
+      ]
+    }
   },
   javascript: {
     documentSelector: [