fix: Dispose services as soon as no one is using them

Author: CGNonofr

src/languageClient.ts

@@ -5,7 +5,7 @@ import {
 import delay from 'delay'
 import { Uri } from 'monaco-editor'
 import { registerTextModelContentProvider } from '@codingame/monaco-editor-wrapper'
-import { installServices } from './services'
+import { getServices, installServices } from './services'
 import createLanguageClient from './createLanguageClient'
 import { WillShutdownParams } from './customRequests'
 import { InitializeTextDocumentFeature, WillDisposeFeature } from './extensions'
@@ -277,10 +277,10 @@ function createLanguageClientManager (
     }
   }
 
-  const services = installServices(infrastructure)
-
   const disposableCollection = new DisposableCollection()
 
+  disposableCollection.push(installServices(infrastructure))
+
   const languageClientManager = new LanguageClientManager(id, languageServerOptions, infrastructure)
   languageClientManagerByLanguageId[id] = languageClientManager
   disposableCollection.push(Disposable.create(() => {
@@ -293,7 +293,7 @@ function createLanguageClientManager (
       return content != null ? monaco.editor.createModel(content, undefined, resource) : null
     }
   }))
-  disposableCollection.push(services.workspace.registerSaveDocumentHandler({
+  disposableCollection.push(getServices().workspace.registerSaveDocumentHandler({
     async saveTextContent (textDocument, reason) {
       await infrastructure.saveFileContent?.(textDocument, reason, languageClientManager)
     }

src/services.ts

@@ -54,29 +54,49 @@ function autoSaveModels (services: CgMonacoServices): Disposable {
 }
 
 let services: CgMonacoServices | null = null
-function installServices (infrastructure: Infrastructure): CgMonacoServices {
-  const m2p = new MonacoToProtocolConverter(monaco)
-  const p2m = new ProtocolToMonacoConverter(monaco)
-
+let serviceDisposable: Disposable | null = null
+let serviceReferenceCount = 0
+function installServices (infrastructure: Infrastructure): Disposable {
   if (services == null) {
+    // FIXME: we can't recreate services because MonacoWorkspace can't be disposed without memory leaks
+    // fix me as soon as https://github.com/TypeFox/monaco-languageclient/pull/330/files is released
+    const m2p = new MonacoToProtocolConverter(monaco)
+    const p2m = new ProtocolToMonacoConverter(monaco)
     services = {
       commands: new MonacoCommands(monaco),
       languages: new MonacoLanguages(monaco, p2m, m2p),
       workspace: new CodinGameMonacoWorkspace(p2m, m2p, infrastructure.rootUri, infrastructure.workspaceFolders),
       window: new WatchableConsoleWindow()
     }
+  }
 
-    Services.install(services)
+  if (serviceReferenceCount === 0) {
+    const disposableCollection = new DisposableCollection()
 
-    installCommands(services)
+    disposableCollection.push(installCommands(services))
+    disposableCollection.push(Services.install(services))
 
     if (!infrastructure.automaticTextDocumentUpdate) {
-      autoSaveModels(services)
+      disposableCollection.push(autoSaveModels(services))
     }
+    serviceDisposable = disposableCollection
   }
-  return services
+  serviceReferenceCount++
+
+  return Disposable.create(() => {
+    serviceReferenceCount--
+    if (serviceReferenceCount <= 0) {
+      serviceDisposable?.dispose()
+      serviceDisposable = null
+    }
+  })
+}
+
+function getServices (): CgMonacoServices {
+  return Services.get()! as CgMonacoServices
 }
 
 export {
-  installServices
+  installServices,
+  getServices
 }