Skip to content

Commit 63f5efe

Browse files
authored
Merge pull request #13 from CodinGame/add-dynamic-options
Add dynamic options and simplify status
2 parents deca2b6 + 706e1f8 commit 63f5efe

File tree

8 files changed

+100
-169
lines changed

8 files changed

+100
-169
lines changed

package-lock.json

Lines changed: 38 additions & 123 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@codingame/monaco-languageclient-wrapper",
3-
"version": "1.6.0",
3+
"version": "1.7.1",
44
"private": false,
55
"description": "Enhanced Monaco editor with TextMate grammars and more",
66
"scripts": {
@@ -21,7 +21,7 @@
2121
],
2222
"types": "dist/index.d.ts",
2323
"dependencies": {
24-
"@codingame/monaco-editor-wrapper": "^1.5.0",
24+
"@codingame/monaco-editor-wrapper": "^1.6.0",
2525
"once": "^1.4.0",
2626
"sweetalert": "^2.1.2"
2727
},
@@ -35,25 +35,23 @@
3535
"@codingame/monaco-jsonrpc": "^0.3.1",
3636
"@codingame/monaco-languageclient": "^0.17.4",
3737
"@rollup/plugin-alias": "3.1.9",
38-
"@rollup/plugin-babel": "5.3.0",
39-
"@rollup/plugin-commonjs": "21.0.1",
38+
"@rollup/plugin-babel": "5.3.1",
39+
"@rollup/plugin-commonjs": "21.0.2",
4040
"@rollup/plugin-eslint": "8.0.1",
4141
"@rollup/plugin-json": "4.1.0",
4242
"@rollup/plugin-node-resolve": "13.1.3",
43-
"@rollup/plugin-typescript": "^8.3.0",
43+
"@rollup/plugin-typescript": "^8.3.1",
4444
"@types/once": "^1.4.0",
4545
"@types/rollup-plugin-node-builtins": "^2.1.2",
4646
"@types/vscode": "^1.64.0",
4747
"@typescript-eslint/eslint-plugin": "5.12.1",
4848
"@typescript-eslint/parser": "5.12.1",
49-
"babel-eslint": "10.1.0",
5049
"eslint": "8.9.0",
5150
"eslint-config-standard": "16.0.3",
5251
"eslint-config-standard-jsx": "10.0.0",
5352
"eslint-plugin-import": "2.25.4",
5453
"eslint-plugin-node": "11.1.0",
5554
"eslint-plugin-promise": "6.0.0",
56-
"eslint-plugin-standard": "5.0.0",
5755
"eslint-plugin-unused-imports": "2.0.0",
5856
"proxy-polyfill": "^0.3.2",
5957
"rollup": "2.68.0",

src/createLanguageClient.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ import { createWebSocketConnection, ConsoleLogger, toSocket, MessageSignature }
22
import { Uri } from 'monaco-editor'
33
import {
44
MonacoLanguageClient,
5-
createConnection, ConnectionErrorHandler, ConnectionCloseHandler, IConnection, Middleware, ErrorHandler, IConnectionProvider, InitializeParams, RegistrationRequest, RegistrationParams, UnregistrationRequest, UnregistrationParams
5+
createConnection, ConnectionErrorHandler, ConnectionCloseHandler, IConnection, Middleware, ErrorHandler, IConnectionProvider, InitializeParams, RegistrationRequest, RegistrationParams, UnregistrationRequest, UnregistrationParams, LanguageClientOptions
66
} from '@codingame/monaco-languageclient'
77
import once from 'once'
88
import { registerExtensionFeatures } from './extensions'
9-
import { LanguageClientId, StaticLanguageClientOptions } from './staticOptions'
9+
import { LanguageClientId } from './languageClientOptions'
1010

1111
async function openConnection (url: URL | string, errorHandler: ConnectionErrorHandler, closeHandler: () => void): Promise<IConnection> {
1212
return new Promise((resolve, reject) => {
@@ -128,7 +128,7 @@ function createLanguageClient (
128128
documentSelector,
129129
synchronize,
130130
initializationOptions
131-
}: StaticLanguageClientOptions,
131+
}: LanguageClientOptions,
132132
languageServerAddress: string,
133133
getSecurityToken: () => Promise<string>,
134134
libraryUrls: string[],

src/extensionConfiguration.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { loadConfigurationForExtension } from '@codingame/monaco-editor-wrapper/dist/features/extensionConfigurations'
2-
import staticOptions, { LanguageClientId } from './staticOptions'
2+
import { getLanguageClientOptions, LanguageClientId } from './languageClientOptions'
33

44
/**
55
* Load the configuration schemas from vscode extensions
@@ -9,7 +9,7 @@ import staticOptions, { LanguageClientId } from './staticOptions'
99
export async function loadExtensionConfigurations (forLanguageClientIds: LanguageClientId[], useMutualizedProxy: boolean): Promise<void> {
1010
const extensionConfigurationToLoad = new Set<string>()
1111
for (const languageClientId of forLanguageClientIds) {
12-
const config = staticOptions[languageClientId]
12+
const config = getLanguageClientOptions(languageClientId)
1313
if (!config.mutualizable || !useMutualizedProxy) {
1414
config.vscodeExtensionIds?.forEach(extensionId => {
1515
extensionConfigurationToLoad.add(extensionId)

0 commit comments

Comments
 (0)