fix: Use common TS config

Author: CGNonofr

package-lock.json

@@ -38,6 +38,7 @@
     "@babel/preset-typescript": "7.17.12",
     "@babel/runtime": "7.18.3",
     "@codingame/eslint-config": "^1.1.2",
+    "@codingame/tsconfig": "^1.0.5",
     "@rollup/plugin-alias": "3.1.9",
     "@rollup/plugin-babel": "5.3.1",
     "@rollup/plugin-commonjs": "22.0.0",

package.json

@@ -14,7 +14,7 @@ const plugin: PluginImpl<{}> = () => {
         lines.splice(index, 1)
         for (; lines[index] !== '}'; index++) {
           // unindent
-          lines[index] = lines[index].slice(4)
+          lines[index] = lines[index]!.slice(4)
         }
         lines.splice(index, 1)
 

rollup/rollup-plugin-remove-vscode-declare-module.ts

@@ -5,7 +5,7 @@ import { StaticFeature, FeatureState, ProtocolRequestType } from 'vscode-languag
 import { DocumentSelector, ServerCapabilities } from 'vscode-languageserver-protocol'
 import * as vscode from 'vscode'
 
-export const ResolveCobolSubroutineRequestType = new ProtocolRequestType<string, string, never, void, void>('cobol/resolveSubroutine')
+export const ResolveCobolSubroutineRequestType = new ProtocolRequestType<string, string | undefined, never, void, void>('cobol/resolveSubroutine')
 export class CobolResolveSubroutineFeature implements StaticFeature {
   private onRequestDisposable: Disposable | undefined
   constructor (private languageClient: MonacoLanguageClient) {
@@ -14,7 +14,7 @@ export class CobolResolveSubroutineFeature implements StaticFeature {
   fillClientCapabilities (): void {}
 
   initialize (capabilities: ServerCapabilities, documentSelector: DocumentSelector): void {
-    this.onRequestDisposable = this.languageClient.onRequest(ResolveCobolSubroutineRequestType, (routineName: string): string => {
+    this.onRequestDisposable = this.languageClient.onRequest(ResolveCobolSubroutineRequestType, (routineName: string): string | undefined => {
       const constantRoutinePaths: Partial<Record<string, string>> = {
         'assert-equals': `file:${vscode.workspace.rootPath ?? '/tmp/project'}/deps/assert-equals.cbl`
       }

src/extensions/cobol.ts

@@ -13,7 +13,7 @@ function lookUp (tree: any, key: string) {
   const parts = key.split('.')
   let node = tree
   for (let i = 0; node != null && i < parts.length; i++) {
-    node = node[parts[i]]
+    node = node[parts[i]!]
   }
   return node
 }

src/services/Configuration.ts

@@ -1,38 +1,25 @@
 {
+  "extends": "@codingame/tsconfig",
   "compilerOptions": {
-    "allowSyntheticDefaultImports": true,
-    "strict": true,
     "baseUrl": "./src",
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
     "isolatedModules": true,
     "lib": [
       "dom",
       "dom.iterable",
       "esnext"
     ],
     "module": "esnext",
-    "moduleResolution": "node",
     "noEmit": true,
     "paths": {
       "app/*": [
         "*"
       ]
     },
-    "resolveJsonModule": true,
-    "sourceMap": true,
-    "target": "es5"
+    "sourceMap": true
   },
   "include": ["src", "rollup", "update-extensions.ts", "rollup.config.ts", "rollup.types.config.ts"],
   "exclude": [
     "dist",
     "node_modules"
-  ],
-  "ts-node": {
-    // these options are overrides used only by ts-node
-    // same as our --compilerOptions flag and our TS_NODE_COMPILER_OPTIONS environment variable
-    "compilerOptions": {
-      "module": "commonjs"
-    }
-  }
+  ]
 }