Skip to content

Commit e941abf

Browse files
authored
Merge pull request #87 from CodinGame/fix-vue-lsp-d.ts
Fix vue lsp d.ts
2 parents c555a77 + dbe91e7 commit e941abf

File tree

2 files changed

+18
-32
lines changed

2 files changed

+18
-32
lines changed

src/languageClientOptions.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import staticOptions, { StaticLanguageClientId } from './staticOptions'
55
import { MonacoLanguageClient } from './createLanguageClient'
66

77
export type LanguageClientOptions = Pick<BaseLanguageClientOptions, 'documentSelector' | 'synchronize' | 'initializationOptions' | 'middleware' | 'errorHandler'> & {
8-
vscodeExtensionIds?: string[]
98
defaultConfigurationOverride?: Record<string, unknown>
109
/**
1110
* Is this language server mutualizable by the CodinGame mutualized proxy

src/staticOptions.ts

Lines changed: 18 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ const staticOptions = asLanguageClientOptionsById({
2727
pattern: '**/*.ts'
2828
}
2929
],
30-
mutualizable: true,
31-
vscodeExtensionIds: ['typescript-language-features', 'angular']
30+
mutualizable: true
3231
},
3332
bash: {
3433
documentSelector: [
@@ -47,15 +46,12 @@ const staticOptions = asLanguageClientOptionsById({
4746
],
4847
middleware: clangdHotfixMiddleware,
4948
mutualizable: false
50-
// The extension is cpptools BUT the language server is unable to use the client configuration (it requires client code)
51-
// vscodeExtensionIds: ['cpptools']
5249
},
5350
csharp: {
5451
documentSelector: [
5552
{ scheme: 'file', language: 'csharp' }
5653
],
5754
mutualizable: true,
58-
vscodeExtensionIds: ['omnisharp'],
5955
middleware: {
6056
async provideDefinition (document, position, token, next) {
6157
const definition = await next(document, position, token)
@@ -88,8 +84,6 @@ const staticOptions = asLanguageClientOptionsById({
8884
],
8985
middleware: clangdHotfixMiddleware,
9086
mutualizable: false
91-
// The extension is cpptools BUT the language server is unable to use the client configuration (it requires client code)
92-
// vscodeExtensionIds: ['cpptools']
9387
},
9488
clojure: {
9589
documentSelector: [
@@ -107,7 +101,6 @@ const staticOptions = asLanguageClientOptionsById({
107101
configurationSection: 'cobol-lsp'
108102
},
109103
mutualizable: false,
110-
vscodeExtensionIds: ['cobol'],
111104
defaultConfigurationOverride: {
112105
'cobol-lsp.subroutine-manager.paths-local': ['/tmp/project']
113106
},
@@ -126,8 +119,7 @@ const staticOptions = asLanguageClientOptionsById({
126119
language: 'dart'
127120
}
128121
],
129-
mutualizable: true,
130-
vscodeExtensionIds: ['dart']
122+
mutualizable: true
131123
},
132124
go: {
133125
documentSelector: [
@@ -138,7 +130,6 @@ const staticOptions = asLanguageClientOptionsById({
138130
{ language: 'tmpl', scheme: 'file' }
139131
],
140132
mutualizable: true,
141-
vscodeExtensionIds: ['vscode-go'],
142133
defaultConfigurationOverride: {
143134
gopls: {
144135
'ui.navigation.importShortcut': 'Definition'
@@ -152,8 +143,7 @@ const staticOptions = asLanguageClientOptionsById({
152143
synchronize: {
153144
configurationSection: 'groovy'
154145
},
155-
mutualizable: true,
156-
vscodeExtensionIds: ['vscode-groovy']
146+
mutualizable: true
157147
},
158148
java: {
159149
documentSelector: [
@@ -165,7 +155,6 @@ const staticOptions = asLanguageClientOptionsById({
165155
configurationSection: ['java', 'editor.insertSpaces', 'editor.tabSize']
166156
},
167157
mutualizable: true,
168-
vscodeExtensionIds: ['java'],
169158
async createAdditionalFeatures (client) {
170159
const { JavaExtensionFeature } = await import('./extensions/java')
171160
return [
@@ -196,10 +185,14 @@ const staticOptions = asLanguageClientOptionsById({
196185
scheme: 'file',
197186
pattern: '**/**.{js,jsx}',
198187
language: 'javascript'
188+
},
189+
{
190+
scheme: 'file',
191+
pattern: '**/*.{ts}',
192+
language: 'typescript'
199193
}
200194
],
201-
mutualizable: true,
202-
vscodeExtensionIds: ['typescript-language-features']
195+
mutualizable: true
203196
},
204197
kotlin: {
205198
// https://github.com/fwcd/vscode-kotlin/blob/db5916080868a6a8e064c60d49624926c2fa61bd/src/languageSetup.ts#L104
@@ -221,7 +214,6 @@ const staticOptions = asLanguageClientOptionsById({
221214
configurationSection: 'Lua'
222215
},
223216
mutualizable: true,
224-
vscodeExtensionIds: ['lua'],
225217
defaultConfigurationOverride: {
226218
'Lua.runtime.version': 'Lua 5.4',
227219
'Lua.diagnostics.enable': true,
@@ -256,8 +248,6 @@ const staticOptions = asLanguageClientOptionsById({
256248
],
257249
middleware: clangdHotfixMiddleware,
258250
mutualizable: false
259-
// The extension is cpptools BUT the language server is unable to use the client configuration (it requires client code)
260-
// vscodeExtensionIds: ['cpptools']
261251
},
262252
'php-serenata': {
263253
// https://gitlab.com/Serenata/visual-studio-code-client/-/blob/master/src/extension.ts#L120
@@ -315,8 +305,7 @@ const staticOptions = asLanguageClientOptionsById({
315305
synchronize: {
316306
configurationSection: 'python'
317307
},
318-
mutualizable: true,
319-
vscodeExtensionIds: ['vscode-python']
308+
mutualizable: true
320309
},
321310
r: {
322311
// https://github.com/REditorSupport/vscode-R/blob/96ed4740101d8cd82f908b415df1dd205b4be824/src/languageService.ts#L186
@@ -328,7 +317,6 @@ const staticOptions = asLanguageClientOptionsById({
328317
configurationSection: 'r.lsp'
329318
},
330319
mutualizable: true,
331-
vscodeExtensionIds: ['vscode-R'],
332320
defaultConfigurationOverride: {
333321
'r.lsp.diagnostics': false
334322
}
@@ -341,16 +329,14 @@ const staticOptions = asLanguageClientOptionsById({
341329
}
342330
],
343331
synchronize: {},
344-
mutualizable: true,
345-
vscodeExtensionIds: ['typescript-language-features']
332+
mutualizable: true
346333
},
347334
ruby: {
348335
// https://github.com/castwide/vscode-solargraph/blob/3ebd9241f013305a84ec64334fca45b487bde904/src/language-client.ts#L56
349336
documentSelector: [
350337
{ scheme: 'file', language: 'ruby' }
351338
],
352339
mutualizable: true,
353-
vscodeExtensionIds: ['solargraph'],
354340
defaultConfigurationOverride: {
355341
'solargraph.diagnostics': true,
356342
'solargraph.formatting': true
@@ -374,7 +360,6 @@ const staticOptions = asLanguageClientOptionsById({
374360
configurationSection: 'metals'
375361
},
376362
mutualizable: false,
377-
vscodeExtensionIds: ['scalameta'],
378363
maxInitializeDuration: 60_000,
379364
readinessMessageMatcher: /compiled scala-project in/
380365
},
@@ -407,8 +392,7 @@ const staticOptions = asLanguageClientOptionsById({
407392
}
408393
],
409394
synchronize: {},
410-
mutualizable: true,
411-
vscodeExtensionIds: ['typescript-language-features']
395+
mutualizable: true
412396
},
413397
verilog: {
414398
documentSelector: [
@@ -418,7 +402,6 @@ const staticOptions = asLanguageClientOptionsById({
418402
}
419403
],
420404
mutualizable: false,
421-
vscodeExtensionIds: ['svlangserver'],
422405
defaultConfigurationOverride: {
423406
'systemverilog.linter': 'icarus',
424407
'systemverilog.launchConfiguration': 'iverilog -g2012 -t null'
@@ -430,11 +413,15 @@ const staticOptions = asLanguageClientOptionsById({
430413
scheme: 'file',
431414
pattern: '**/*.js',
432415
language: 'javascript'
416+
},
417+
{
418+
scheme: 'file',
419+
pattern: '**/*.{ts}',
420+
language: 'typescript'
433421
}
434422
],
435423
synchronize: {},
436-
mutualizable: true,
437-
vscodeExtensionIds: ['typescript-language-features']
424+
mutualizable: true
438425
}
439426
})
440427

0 commit comments

Comments
 (0)