fix: fix terminals

Author: Loïc Mangeonjean

demo/src/features/terminal.ts

@@ -3,8 +3,8 @@ import ansiColors from 'ansi-colors'
 import * as vscode from 'vscode'
 
 export class TerminalBackend extends SimpleTerminalBackend {
-  getDefaultSystemShell = async (): Promise<string> => 'fake'
-  createProcess = async (): Promise<ITerminalChildProcess> => {
+  override getDefaultSystemShell = async (): Promise<string> => 'fake'
+  override createProcess = async (): Promise<ITerminalChildProcess> => {
     const dataEmitter = new vscode.EventEmitter<string>()
     const propertyEmitter = new vscode.EventEmitter<{
       type: string
@@ -23,13 +23,13 @@ export class TerminalBackend extends SimpleTerminalBackend {
         return undefined
       }
 
-      onDidChangeProperty = propertyEmitter.event
+      override onDidChangeProperty = propertyEmitter.event
 
-      shutdown (immediate: boolean): void {
+      override shutdown (immediate: boolean): void {
         console.log('shutdown', immediate)
       }
 
-      input (data: string): void {
+      override input (data: string): void {
         for (const c of data) {
           if (c.charCodeAt(0) === 13) {
             dataEmitter.fire(`\r\n${ansiColors.green('$')} `)
@@ -49,6 +49,9 @@ export class TerminalBackend extends SimpleTerminalBackend {
       resize (cols: number, rows: number): void {
         console.log('resize', cols, rows)
       }
+
+      override clearBuffer (): void | Promise<void> {
+      }
     }
     return new FakeTerminalProcess(1, 1, '/tmp', dataEmitter.event)
   }

scripts/vscode.patch

@@ -690,6 +690,36 @@ index ff766b9acb8..599bab9dd59 100644
  	}
 
  	isVisible(): boolean {
+diff --git a/src/vs/workbench/contrib/terminal/browser/terminalService.ts b/src/vs/workbench/contrib/terminal/browser/terminalService.ts
+index 34b62b8fb2b..66d4b7bb70f 100644
+--- a/src/vs/workbench/contrib/terminal/browser/terminalService.ts
++++ b/src/vs/workbench/contrib/terminal/browser/terminalService.ts
+@@ -19,7 +19,7 @@ import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/c
+ import { IDialogService } from 'vs/platform/dialogs/common/dialogs';
+ import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
+ import { INotificationService } from 'vs/platform/notification/common/notification';
+-import { ICreateContributedTerminalProfileOptions, IPtyHostAttachTarget, IRawTerminalInstanceLayoutInfo, IRawTerminalTabLayoutInfo, IShellLaunchConfig, ITerminalBackend, ITerminalLaunchError, ITerminalLogService, ITerminalsLayoutInfo, ITerminalsLayoutInfoById, TerminalExitReason, TerminalLocation, TerminalLocationString, TitleEventSource } from 'vs/platform/terminal/common/terminal';
++import { ICreateContributedTerminalProfileOptions, IPtyHostAttachTarget, IRawTerminalInstanceLayoutInfo, IRawTerminalTabLayoutInfo, IShellLaunchConfig, ITerminalBackend, ITerminalBackendRegistry, ITerminalLaunchError, ITerminalLogService, ITerminalsLayoutInfo, ITerminalsLayoutInfoById, TerminalExitReason, TerminalExtensions, TerminalLocation, TerminalLocationString, TitleEventSource } from 'vs/platform/terminal/common/terminal';
+ import { formatMessageForTerminal } from 'vs/platform/terminal/common/terminalStrings';
+ import { iconForeground } from 'vs/platform/theme/common/colorRegistry';
+ import { getIconRegistry } from 'vs/platform/theme/common/iconRegistry';
+@@ -52,6 +52,7 @@ import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
+ import { TerminalCapabilityStore } from 'vs/platform/terminal/common/capabilities/terminalCapabilityStore';
+ import { ITimerService } from 'vs/workbench/services/timer/browser/timerService';
+ import { mark } from 'vs/base/common/performance';
++import { Registry } from 'vs/platform/registry/common/platform';
+ 
+ export class TerminalService implements ITerminalService {
+ 	declare _serviceBrand: undefined;
+@@ -213,7 +214,7 @@ export class TerminalService implements ITerminalService {
+ 		this._handleInstanceContextKeys();
+ 		this._terminalShellTypeContextKey = TerminalContextKeys.shellType.bindTo(this._contextKeyService);
+ 		this._processSupportContextKey = TerminalContextKeys.processSupported.bindTo(this._contextKeyService);
+-		this._processSupportContextKey.set(!isWeb || this._remoteAgentService.getConnection() !== null);
++		this._processSupportContextKey.set(!isWeb || this._remoteAgentService.getConnection() !== null || Registry.as<ITerminalBackendRegistry>(TerminalExtensions.Backend).getTerminalBackend() !== undefined);
+ 		this._terminalHasBeenCreated = TerminalContextKeys.terminalHasBeenCreated.bindTo(this._contextKeyService);
+ 		this._terminalCountContextKey = TerminalContextKeys.count.bindTo(this._contextKeyService);
+ 		this._terminalEditorActive = TerminalContextKeys.terminalEditorActive.bindTo(this._contextKeyService);
 diff --git a/src/vs/workbench/contrib/webview/browser/pre/service-worker.js b/src/vs/workbench/contrib/webview/browser/pre/service-worker.js
 index a6e9943b866..c470a1c9ed5 100644
 --- a/src/vs/workbench/contrib/webview/browser/pre/service-worker.js