Skip to content

Commit 764200d

Browse files
author
Loïc Mangeonjean
committed
feat: automatically add quickaccess service override
with proper arguments
1 parent 8fa91ca commit 764200d

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

src/service-override/quickaccess.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ import 'vs/workbench/browser/actions/quickAccessActions'
1717
import 'vs/workbench/contrib/quickaccess/browser/quickAccess.contribution'
1818

1919
let isKeybindingConfigurationVisible = () => {
20-
return true
20+
return false
2121
}
2222
let shouldUseGlobalPicker = () => {
23-
return true
23+
return false
2424
}
2525

2626
// eslint-disable-next-line dot-notation

src/service-override/views.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ import { ILayoutService } from 'vs/platform/layout/browser/layoutService'
9999
import { OpenEditor, wrapOpenEditor } from './tools/editor'
100100
import getBulkEditServiceOverride from './bulkEdit'
101101
import getLayoutServiceOverride, { LayoutService } from './layout'
102+
import getQuickAccessOverride from './quickaccess'
102103
import { changeUrlDomain } from './tools/url'
103104
import { registerAssets } from '../assets'
104105
import { registerServiceInitializePostParticipant } from '../services'
@@ -542,6 +543,10 @@ export default function getServiceOverride (openEditorFallback?: OpenEditor, _we
542543
return {
543544
...getLayoutServiceOverride(),
544545
...getBulkEditServiceOverride(),
546+
...getQuickAccessOverride({
547+
isKeybindingConfigurationVisible: isEditorPartVisible,
548+
shouldUseGlobalPicker: isEditorPartVisible
549+
}),
545550
[IViewsService.toString()]: new SyncDescriptor(ViewsService, [], false),
546551
[IViewDescriptorService.toString()]: new SyncDescriptor(ViewDescriptorService, [], true),
547552
[IActivityService.toString()]: new SyncDescriptor(ActivityService, [], true),

src/services.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import getLayoutServiceOverride from './service-override/layout'
1515
import getEnvironmentServiceOverride from './service-override/environment'
1616
import getExtensionsServiceOverride from './service-override/extensions'
1717
import getFileServiceOverride from './service-override/files'
18+
import getQuickAccessOverride from './service-override/quickaccess'
1819

1920
interface ServiceInitializeParticipant {
2021
(accessor: ServicesAccessor): Promise<void>
@@ -38,6 +39,7 @@ async function initServices (overrides: IEditorOverrideServices): Promise<IInsta
3839
...getEnvironmentServiceOverride(),
3940
...getExtensionsServiceOverride(),
4041
...getFileServiceOverride(),
42+
...getQuickAccessOverride(),
4143
...overrides
4244
})
4345

0 commit comments

Comments
 (0)