feat: split view service overrides

Author: Loïc Mangeonjean

src/service-override/viewBanner.ts

@@ -0,0 +1,15 @@
+import '../missing-services'
+import { IEditorOverrideServices } from 'vs/editor/standalone/browser/standaloneServices'
+import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors'
+import { BannerPart } from 'vs/workbench/browser/parts/banner/bannerPart'
+import { IBannerService } from 'vs/workbench/services/banner/browser/bannerService'
+
+export default function getServiceOverride (): IEditorOverrideServices {
+  return {
+    [IBannerService.toString()]: new SyncDescriptor(BannerPart, [], false)
+  }
+}
+
+export {
+  BannerPart
+}

src/service-override/viewStatusBar.ts

@@ -0,0 +1,15 @@
+import '../missing-services'
+import { IEditorOverrideServices } from 'vs/editor/standalone/browser/standaloneServices'
+import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors'
+import { StatusbarPart } from 'vs/workbench/browser/parts/statusbar/statusbarPart'
+import { IStatusbarService } from 'vs/workbench/services/statusbar/browser/statusbar'
+
+export default function getServiceOverride (): IEditorOverrideServices {
+  return {
+    [IStatusbarService.toString()]: new SyncDescriptor(StatusbarPart, [], false)
+  }
+}
+
+export {
+  StatusbarPart
+}

src/service-override/viewTitleBar.ts

@@ -0,0 +1,15 @@
+import '../missing-services'
+import { IEditorOverrideServices } from 'vs/editor/standalone/browser/standaloneServices'
+import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors'
+import { ITitleService } from 'vs/workbench/services/title/common/titleService'
+import { TitlebarPart } from 'vs/workbench/browser/parts/titlebar/titlebarPart'
+
+export default function getServiceOverride (): IEditorOverrideServices {
+  return {
+    [ITitleService.toString()]: new SyncDescriptor(TitlebarPart, [], false)
+  }
+}
+
+export {
+  TitlebarPart
+}

src/service-override/views.ts

@@ -61,7 +61,6 @@ import { IResolvedTextEditorModel } from 'vs/editor/common/services/resolverServ
 import { ITextEditorService, TextEditorService } from 'vs/workbench/services/textfile/common/textEditorService'
 import { CodeEditorService } from 'vs/workbench/services/editor/browser/codeEditorService'
 import { IUntitledTextEditorService, UntitledTextEditorService } from 'vs/workbench/services/untitled/common/untitledTextEditorService'
-import { StatusbarPart } from 'vs/workbench/browser/parts/statusbar/statusbarPart'
 import { IStatusbarService } from 'vs/workbench/services/statusbar/browser/statusbar'
 import { IHistoryService } from 'vs/workbench/services/history/common/history'
 import { HistoryService } from 'vs/workbench/services/history/browser/historyService'
@@ -88,10 +87,8 @@ import { IStorageService } from 'vs/platform/storage/common/storage'
 import { IThemeService } from 'vs/platform/theme/common/themeService'
 import { ConfirmResult } from 'vs/platform/dialogs/common/dialogs'
 import { ILayoutService } from 'vs/platform/layout/browser/layoutService'
-import { BannerPart } from 'vs/workbench/browser/parts/banner/bannerPart'
 import { IBannerService } from 'vs/workbench/services/banner/browser/bannerService'
 import { ITitleService } from 'vs/workbench/services/title/common/titleService'
-import { TitlebarPart } from 'vs/workbench/browser/parts/titlebar/titlebarPart'
 import { MonacoDelegateEditorGroupsService, MonacoEditorService, OpenEditor } from './tools/editor'
 import getBulkEditServiceOverride from './bulkEdit'
 import getLayoutServiceOverride, { LayoutService } from './layout'
@@ -572,9 +569,10 @@ registerServiceInitializePostParticipant(async (accessor) => {
   const viewDescriptorService = accessor.get(IViewDescriptorService)
 
   // force service instantiation
-  accessor.get(IStatusbarService)
-  accessor.get(IBannerService)
-  accessor.get(ITitleService)
+  const withStatusBar = accessor.get(IStatusbarService) instanceof Part
+  const withBannerPart = accessor.get(IBannerService) instanceof Part
+  const withTitlePart = accessor.get(ITitleService) instanceof Part
+
   paneCompositePartService.getPaneComposites(ViewContainerLocation.Panel)
 
   const layoutService = accessor.get(ILayoutService) as LayoutService
@@ -584,16 +582,20 @@ registerServiceInitializePostParticipant(async (accessor) => {
   document.body.append(invisibleContainer)
 
   // Create Parts
-  for (const { id, role, classes, options } of [
-    { id: Parts.TITLEBAR_PART, role: 'none', classes: ['titlebar'] },
-    { id: Parts.BANNER_PART, role: 'banner', classes: ['banner'] },
+  for (const { id, role, classes, options, enabled = true } of [
+    { id: Parts.TITLEBAR_PART, role: 'none', classes: ['titlebar'], enabled: withTitlePart },
+    { id: Parts.BANNER_PART, role: 'banner', classes: ['banner'], enabled: withBannerPart },
     { id: Parts.ACTIVITYBAR_PART, role: 'none', classes: ['activitybar', 'left'] },
     { id: Parts.SIDEBAR_PART, role: 'none', classes: ['sidebar', 'left'] },
     { id: Parts.EDITOR_PART, role: 'main', classes: ['editor'], options: { restorePreviousState: false } },
     { id: Parts.PANEL_PART, role: 'none', classes: ['panel', 'basepanel', positionToString(Position.BOTTOM)] },
     { id: Parts.AUXILIARYBAR_PART, role: 'none', classes: ['auxiliarybar', 'basepanel', 'right'] },
-    { id: Parts.STATUSBAR_PART, role: 'status', classes: ['statusbar'] }
+    { id: Parts.STATUSBAR_PART, role: 'status', classes: ['statusbar'], enabled: withStatusBar }
   ]) {
+    if (!enabled) {
+      continue
+    }
+
     const partContainer = createPart(id, role, classes)
 
     const part = layoutService.getPart(id)
@@ -633,9 +635,6 @@ export default function getServiceOverride (openEditorFallback?: OpenEditor, _we
     [ICodeEditorService.toString()]: new SyncDescriptor(CodeEditorService, [], true),
     [ITextEditorService.toString()]: new SyncDescriptor(TextEditorService, [], false),
     [IEditorGroupsService.toString()]: new SyncDescriptor(MonacoEditorPart, [], false),
-    [ITitleService.toString()]: new SyncDescriptor(TitlebarPart, [], false),
-    [IBannerService.toString()]: new SyncDescriptor(BannerPart, [], false),
-    [IStatusbarService.toString()]: new SyncDescriptor(StatusbarPart, [], false),
     [IEditorDropService.toString()]: new SyncDescriptor(EditorDropService, [], true),
     [IEditorService.toString()]: new SyncDescriptor(MonacoEditorService, [openEditorFallback, isEditorPartVisible], false),
     [IEditorResolverService.toString()]: new SyncDescriptor(EditorResolverService, [], false),
@@ -680,7 +679,6 @@ export {
 
   HoverService,
   ActivityService,
-  StatusbarPart,
   SidebarPart,
   ActivitybarPart,
   PanelPart,