Adding extralibs

[vitor-txt]

Hi! In the past, when I used the Monaco Editor, I was able to add .d.ts files to JavaScript with the command monaco.languages.typescript.javascriptDefaults.addExtraLib(libSource, libUri), similar to what is done here:
https://microsoft.github.io/monaco-editor/playground.html?source=v0.51.0#example-extending-language-services-configure-javascript-defaults

However, for some reason, when I try to perform this action, I am getting undefined for languages.typescript. I have also tried:

• Importing directly to monaco-editor:

import * as monaco from 'monaco-editor';
//same with import * as editor from 'monaco-editor/esm/vs/editor/editor.api';
...
monaco.languages.typescript.javascriptDefaults.addExtraLib(lib)

• Using getApi:

  void getApi().then(async (api: vscodeAPI) => {
      ...
      const extraLib = api.languages.typescript.javascriptDefaults.addExtraLib(lib);

Am I missing something, or is there another way to add libraries?

[CGNonofr]

Hello,

Those apis are added by the monaco standalone typescript worker.

It that project, we tend to encourage using VSCode stuff instead, and you should be able to use the VSCode typescript default extension for the typescript intellisense (cf. the demo). You would be able to add types but adding your .d.ts file in the project directly in the virtual filesystem, or referencing published types (there is a type acquisition feature).

However, there is something that can be blocking for many users: the VSCode typescript extension requires the crossOriginIsolated flag to be enable to fully operate (aka project-wide intellisense).

For that reason, it's still possible to use the monaco typescript worker, you just need to install and import @codingame/monaco-vscode-standalone-typescript-language-features

[CGNonofr]

can you have a look at the v10.1.2?

btw, importing VSCode theme extension without using the theme service override doesn't make sense

[CGNonofr]

(Did you remove your message or is it a github bug?)

[Nuthin2do]

NewEditor.zip

Unfortunately there is still an error. If i run npm run start then the browser shows this error:

But when i run npm run build then it doesn't finish and this error pops up:

error during build:
[vite:worker-import-meta-url] node_modules/@codingame/monaco-vscode-standalone-typescript-language-features/worker.js (2:9): "initialize" is not exported by "node_modules/monaco-editor/esm/vs/editor/editor.worker.js", imported by "node_modules/@codingame/monaco-vscode-standalone-typescript-language-features/worker.js".
file: C:/temp/NewEditor/src/main.ts:2:9

1: import { initialize } from 'monaco-editor/esm/vs/editor/editor.worker.js';
2: export { initialize } from 'monaco-editor/esm/vs/editor/editor.worker.js';
            ^
3:
4: /*!-----------------------------------------------------------------------------

at getRollupError (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/parseAst.js:395:41)
    at error (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/parseAst.js:391:42)
    at Module.error (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/node-entry.js:15551:16)
    at Module.traceVariable (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/node-entry.js:16000:29)
    at ModuleScope.findVariable (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/node-entry.js:13786:39)
    at ReturnValueScope.findVariable (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/node-entry.js:5252:38)
    at FunctionBodyScope.findVariable (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/node-entry.js:5252:38)
    at Identifier.bind (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/node-entry.js:5035:40)
    at CallExpression.bind (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/node-entry.js:2855:23)
    at CallExpression.bind (file:///C:/temp/NewEditor/node_modules/rollup/dist/es/shared/node-entry.js:11251:15)

See the repo with the updated packages.

btw, importing VSCode theme extension without using the theme service override doesn't make sense

If i don't use this import:

import "@codingame/monaco-vscode-theme-defaults-default-extension";

in combination with this:

await initialize(
    {
      ...getModelServiceOverride(),
      ...getThemeServiceOverride(),
      ...getLanguagesServiceOverride(),
      ...getTextMateServiceOverride(),
      ...getConfigurationServiceOverride(),
      ...getDebugServiceOverride(),
    },
    undefined,

then there is no highlighting and changing the theme in the config.json doesn't change anything. Therefore i'm a bit confused what you mean.... I’d appreciate any tips on this. Thank you

[CGNonofr]

Sorry, I made a last-minute refactor that broke it again in a different way... fixed in #527

Regarding the theme service, I was convinced you were'nt using it, I probably misread 🤷

[Nuthin2do]

Now everything works like a charm. Thank you very much 👍