Error in build using vite when updating to 16.0.0

[erickRochaIP]

Hello! I've just updated from 15.0.3 to 16.0.0 and I'm having some errors in build. That's the output:

error during build:
[vite]: Rollup failed to resolve import "@codingame/monaco-vscode-api/vscode/vs/base/browser/cssValue" from "/home/erick/repos/vscode-test/node_modules/.pnpm/@[email protected]/node_modules/@codingame/monaco-vscode-base-service-override/vscode/src/vs/workbench/services/decorations/browser/decorationsService.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

I don't know if it might be related to the following new bugfix: improve build process fdf43b3

[erickRochaIP]

I added the following to vite.config.ts:

  build: {
    rollupOptions: {
      external: ['@codingame/monaco-vscode-api/vscode/vs/base/browser/cssValue'],
    },
  },

Now I have this error:

error during build:
[vite:worker-import-meta-url] ../../node_modules/.pnpm/@codingame+monaco-vscode-standalone-typescript-language-features@16.0.0/node_modules/@codingame/monaco-vscode-standalone-typescript-language-features/worker.js (2:9): "initialize" is not exported by "../../node_modules/.pnpm/@[email protected]/node_modules/@codingame/monaco-vscode-editor-api/esm/vs/editor/editor.worker.js", imported by "../../node_modules/.pnpm/@codingame+monaco-vscode-standalone-typescript-language-features@16.0.0/node_modules/@codingame/monaco-vscode-standalone-typescript-language-features/worker.js".
file: /home/erick/repos/vscode-test/src/options.ts:2:9

1: import { initialize } from 'monaco-editor/esm/vs/editor/editor.worker.js';
2: export { initialize } from 'monaco-editor/esm/vs/editor/editor.worker.js';
            ^
3: 
4: /*!-----------------------------------------------------------------------------

[CGNonofr]

Can you run pnpm list @codingame/monaco-vscode-api?

I suspect you have multiple versions of the lib installed

[CGNonofr]

OR please provide a minimal reproduction repository

[erickRochaIP]

pnpm list @codingame/monaco-vscode-api returns only one dependency: @codingame/monaco-vscode-api 16.0.1 (I updated to this version just now).

After updating vite (5.x -> 6.x) the first error disappeared, but the second one remained.

I noticed that the error message mentions the module @codingame+monaco-vscode-standalone-typescript-language-features@16.0.1, so I tried deleting the import that references the worker of this module:

javascript: () =>
  new Worker(new URL('@codingame/monaco-vscode-standalone-typescript-language-features/worker', import.meta.url), {
    type: 'module',
  }),

After deleting this import the build succeeds. Do you think it might be a bug in this specific module?

[erickRochaIP]

monaco-vscode-standalone-typescript-language-features/worker.js imports a initialize method which is not exported by src/workers/editor.worker.ts. It looks like vscode changed the location of initialize from vs/editor/common/services/editorWorkerBootstrap.js to vs/base/common/worker/webWorkerBootstrap.ts

[CGNonofr]

Workers were refactored on the VSCode side in the last version, and indeed the demo doesn't test the standalone workers 🤔 I'll have a look! thanks

[CGNonofr]

Or is #609 the corresponding fix?

[erickRochaIP]

Thank you for the reply! I tried to solve it, but I think your change in #610 is more correct.

[CGNonofr]

can you have a look at the 16.0.2?

[erickRochaIP]

I updated to 16.0.2 and it solved the problem, thank you very much!