-
Notifications
You must be signed in to change notification settings - Fork 54
Description
I'm trying to upgrade my project (from v7) to v21, and trying to get the new demo working again..
first I tried degit against the demo dir as I had done previously, and swapped the package.json file versions from file:.. to latest versions on npm, and using the npm aliases described in the readme..
this builds, but running the vite server throws an error
[plugin:vite:import-analysis] Cannot read properties of null (reading 'id')
/home/dan/build/pg-playground/monaco-vscode-api/demo/src/setup.common.ts:91:7
85 | import { TerminalBackend } from "./features/terminal";
86 | import { workerConfig } from "./tools/extHostWorker";
87 | import "vscode/localExtensionHost";
I tried a few different variations and tricks to get this to work, but all came up with the same error.
I threw Sonnet 4 via opencode at the problem and after a while it said
The localExtensionHost.js and localExtensionHost.d.ts files are missing from the published npm package./
Based on my analysis:
1. Demo Configuration: ✅ The demo is correctly configured:
• In demo/package.json:199: "vscode": "npm:@codingame/[email protected]" properly aliases the
vscode package
• In demo/vite.config.ts:86: 'vscode/localExtensionHost' is included in optimizeDeps.include
• In demo/src/setup.common.ts:91: import 'vscode/localExtensionHost' is the import causing the issue
2. Source Code: ✅ The source code exists:
• src/localExtensionHost.ts contains the full implementation
• rollup/rollup.config.ts:38 includes localExtensionHost: './src/localExtensionHost.ts' in the build
configuration
3. Published Package: ❌ The issue: The published package @codingame/[email protected] is missing
the compiled localExtensionHost.js and localExtensionHost.d.ts files.
4. Package Exports: ✅ The package.json exports are correctly configured with the wildcard pattern ./*
that should make vscode/localExtensionHost resolve to ./localExtensionHost.js
(but that's LLM output, grain of salt and all that)
then I tried to build the project from source, and when bun install error'd I used npm install and after 20 minutes this thing is still running postinstall scripts, and now I'm not sure I want to upgrade that badly
update: it finished, but running npm run build fails with a TS error