fixed deletion bug and removed empty generator constraint

Author: CodingAP

deno.json

@@ -1,6 +1,6 @@
 {
     "name": "@codingap/steve",
-    "version": "2.0.9",
+    "version": "2.0.10",
     "exports": "./index.ts",
     "description": "STEVE is a configurable template engine that allows JavaScript to run in files to create files. It has a plugin system to allow for custom generation and a built-in site generator.",
     "tasks": {

src/plugin/site-generator.ts

@@ -9,7 +9,7 @@
  */
 
 import { copySync, existsSync, walkSync } from '@std/fs';
-import { join, resolve } from '@std/path';
+import { join, relative } from '@std/path';
 import { STEVE, STEVEPlugin } from '../../index.ts';
 
 /**
@@ -66,12 +66,12 @@ class SingleRoute {
 
     constructor(options: SingleRouteOptions) {
         if (!options.render) {
-            throw new Error("please provide 'render'!");
+            throw new Error('please provide \'render\'!');
         }
         this.#render = options.render;
 
         if (!options.data) {
-            throw new Error("please provide 'data'!");
+            throw new Error('please provide \'data\'!');
         }
         this.#data = options.data;
 
@@ -97,17 +97,17 @@ class GeneratorRoute {
 
     constructor(options: GeneratorRouteOptions) {
         if (!options.render) {
-            throw new Error("please provide 'render'!");
+            throw new Error('please provide \'render\'!');
         }
         this.#render = options.render;
 
         if (!options.data) {
-            throw new Error("please provide 'data'!");
+            throw new Error('please provide \'data\'!');
         }
         this.#data = options.data;
 
-        if (!options.generator || options.generator.length == 0) {
-            throw new Error('please provide a non-empty generator!');
+        if (!options.generator) {
+            throw new Error('please provide \'generator\'!');
         }
         this.#generator = options.generator;
 
@@ -146,7 +146,7 @@ class SiteGenerator extends STEVEPlugin {
         this.#ignoredFiles = options.ignoredFiles ?? [];
         if (!options.outputDirectory) {
             throw new Error(
-                "please provide an 'outputDirectory' for the files to go to!",
+                'please provide an \'outputDirectory\' for the files to go to!',
             );
         }
         this.#outputDirectory = options.outputDirectory;
@@ -159,9 +159,10 @@ class SiteGenerator extends STEVEPlugin {
         // clean up the output directory by removing non-ignored files and directories
         if (existsSync(this.#outputDirectory)) {
             const files = [...walkSync(this.#outputDirectory)].filter(file => {
-                return this.#ignoredFiles?.filter((filename) =>
-                    resolve(file.path).includes(filename)
-                ).length == 0 && !file.name.startsWith('.') && resolve(this.#outputDirectory) !== file.path
+                const filename = relative(this.#outputDirectory, file.path);
+                return this.#ignoredFiles?.filter((f) =>
+                    filename.includes(f)
+                ).length == 0 && !filename.startsWith('.') && filename != ''
             });
 
             for (const file of files) {
@@ -280,7 +281,7 @@ class SiteGenerator extends STEVEPlugin {
 
             if (!this.staticDirectory) {
                 throw new Error(
-                    "there is no 'staticDirectory' defined to get static file!",
+                    'there is no \'staticDirectory\' defined to get static file!',
                 );
             }
 

test/site-generator.test.ts

@@ -10,6 +10,7 @@
 import { assertEquals, assertThrows } from '@std/assert';
 import { ensureDir, exists } from 'jsr:@std/fs';
 import { GeneratorRoute, SingleRoute, SiteGenerator, STEVE } from '../index.ts';
+import { join } from '@std/path/join';
 
 // ~~~~~ SingleRoute testing ~~~~~
 Deno.test('SingleRoute: generates a single route with render content', () => {
@@ -102,20 +103,6 @@ Deno.test("GeneratorRoute: throws error when 'render' is empty", () => {
     );
 });
 
-Deno.test("GeneratorRoute: throws error when 'generator' is empty", () => {
-    assertThrows(
-        () =>
-            new GeneratorRoute({
-                render: 'test string',
-                data: {},
-                isFile: false,
-                generator: [],
-            }),
-        Error,
-        'please provide a non-empty generator!',
-    );
-});
-
 Deno.test('GeneratorRoute: reads template from file when isFile is true', async () => {
     const tempDir = await Deno.makeTempDir();
     const templateFile = `${tempDir}/template.html`;
@@ -278,6 +265,11 @@ Deno.test('SiteGenerator: handles ignored files correctly', async () => {
         `${outputDir}/.system`,
         'This file should not be deleted.',
     );
+    await ensureDir(join(outputDir, '.git'));
+    await Deno.writeTextFile(
+        join(outputDir, '.git', 'HEAD'),
+        'This file should not be deleted.',
+    );
 
     // Create SiteGenerator instance
     const generator = new SiteGenerator({
@@ -294,6 +286,7 @@ Deno.test('SiteGenerator: handles ignored files correctly', async () => {
     // Validate that ignored files remain
     assertEquals(await exists(`${outputDir}/ignore.txt`), true);
     assertEquals(await exists(`${outputDir}/.system`), true);
+    assertEquals(await exists(`${outputDir}/.git/HEAD`), true);
 
     // Validate that non-ignored files are deleted
     assertEquals(await exists(`${outputDir}/delete.txt`), false);