Skip to content

Commit 3952d8e

Browse files
authored
fix(ci): re-enable linting in CI workflow and npm scripts (#34)
- Uncomment lint step in ci.yml - Add lint to "all" npm script - Downgrade eslint from 9.x to 8.x for yaml config compatibility - Remove eslint.config.js (flat config) in favor of .eslintrc.yml - Add .eslintignore for proper file exclusions
1 parent 75faf60 commit 3952d8e

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

.eslintignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
lib/
2+
dist/
3+
node_modules/
4+
coverage/

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ jobs:
3737
id: npm-format-check
3838
run: npm run format:check
3939

40-
# - name: Lint
41-
# id: npm-lint
42-
# run: npm run lint
40+
- name: Lint
41+
id: npm-lint
42+
run: npm run lint
4343

4444
- name: Test
4545
id: npm-ci-test

eslint.config.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"package": "npx ncc build src/index.ts -o dist --source-map --license licenses.txt",
1717
"package:watch": "npm run package -- --watch",
1818
"test": "npx jest",
19-
"all": "npm run format:write && npm run test && npm run coverage && npm run package"
19+
"all": "npm run format:write && npm run lint && npm run test && npm run coverage && npm run package"
2020
},
2121
"engines": {
2222
"node": ">=21"
@@ -40,7 +40,7 @@
4040
"@types/node": "^22.10.1",
4141
"@typescript-eslint/parser": "^8.16.0",
4242
"@vercel/ncc": "^0.38.3",
43-
"eslint": "^9.16.0",
43+
"eslint": "^8.0.1",
4444
"eslint-plugin-github": "^5.1.3",
4545
"eslint-plugin-jest": "^28.9.0",
4646
"jest": "^29.7.0",

0 commit comments

Comments
 (0)