[OpenTelemetry] enable analysis - part 1 (open-telemetry#6263)

Author: Kielek

src/OpenTelemetry/BaseExportProcessor.cs

@@ -35,7 +35,9 @@ public abstract class BaseExportProcessor<T> : BaseProcessor<T>
     /// <summary>
     /// Gets the exporter used by the processor.
     /// </summary>
+#pragma warning disable CA1051 // Do not declare visible instance fields
     protected readonly BaseExporter<T> exporter;
+#pragma warning restore CA1051 // Do not declare visible instance fields
 
     private readonly string friendlyTypeName;
     private bool disposed;

src/OpenTelemetry/BaseProcessor.cs

@@ -17,7 +17,9 @@ public abstract class BaseProcessor<T> : IDisposable
     /// <summary>
     /// Initializes a new instance of the <see cref="BaseProcessor{T}"/> class.
     /// </summary>
+#pragma warning disable CA1012 // Abstract types should not have public constructors
     public BaseProcessor()
+#pragma warning restore CA1012 // Abstract types should not have public constructors
     {
         this.typeName = this.GetType().Name;
     }

src/OpenTelemetry/CompositeProcessor.cs

@@ -27,7 +27,7 @@ public CompositeProcessor(IEnumerable<BaseProcessor<T>> processors)
         using var iter = processors.GetEnumerator();
         if (!iter.MoveNext())
         {
-            throw new ArgumentException($"'{iter}' is null or empty", nameof(iter));
+            throw new ArgumentException($"'{iter}' is null or empty", nameof(processors));
         }
 
         this.Head = new DoublyLinkedListNode(iter.Current);

src/OpenTelemetry/Internal/SelfDiagnosticsConfigRefresher.cs

@@ -139,7 +139,7 @@ private void UpdateMemoryMappedFileFromConfiguration()
         if (this.configParser.TryGetConfiguration(out string? newLogDirectory, out int fileSizeInKB, out EventLevel newEventLevel))
         {
             int newFileSize = fileSizeInKB * 1024;
-            if (!newLogDirectory.Equals(this.logDirectory) || this.logFileSize != newFileSize)
+            if (!newLogDirectory.Equals(this.logDirectory, StringComparison.Ordinal) || this.logFileSize != newFileSize)
             {
                 this.CloseLogFile();
                 this.OpenLogFile(newLogDirectory, newFileSize);
@@ -194,7 +194,11 @@ private void OpenLogFile(string newLogDirectory, int newFileSize)
         {
             Directory.CreateDirectory(newLogDirectory);
             var fileName = Path.GetFileName(Process.GetCurrentProcess().MainModule?.FileName ?? "OpenTelemetrySdk") + "."
+#if NET
+                + Environment.ProcessId + ".log";
+#else
                 + Process.GetCurrentProcess().Id + ".log";
+#endif
             var filePath = Path.Combine(newLogDirectory, fileName);
 
             // Because the API [MemoryMappedFile.CreateFromFile][1](the string version) behaves differently on

src/OpenTelemetry/Internal/SelfDiagnosticsEventListener.cs

@@ -20,9 +20,9 @@ internal sealed class SelfDiagnosticsEventListener : EventListener
     private readonly EventLevel logLevel;
     private readonly SelfDiagnosticsConfigRefresher configRefresher;
     private readonly ThreadLocal<byte[]?> writeBuffer = new(() => null);
-    private readonly List<EventSource>? eventSourcesBeforeConstructor = new();
+    private readonly List<EventSource>? eventSourcesBeforeConstructor = [];
 
-    private bool disposedValue = false;
+    private bool disposedValue;
 
     public SelfDiagnosticsEventListener(EventLevel logLevel, SelfDiagnosticsConfigRefresher configRefresher)
     {
@@ -111,61 +111,6 @@ internal static int EncodeInBuffer(string? str, bool isParameter, byte[] buffer,
         return position;
     }
 
-    internal void WriteEvent(string? eventMessage, ReadOnlyCollection<object?>? payload)
-    {
-        try
-        {
-            var buffer = this.writeBuffer.Value;
-            if (buffer == null)
-            {
-                buffer = new byte[BUFFERSIZE];
-                this.writeBuffer.Value = buffer;
-            }
-
-            var pos = this.DateTimeGetBytes(DateTime.UtcNow, buffer, 0);
-            buffer[pos++] = (byte)':';
-            pos = EncodeInBuffer(eventMessage, false, buffer, pos);
-            if (payload != null)
-            {
-                // Not using foreach because it can cause allocations
-                for (int i = 0; i < payload.Count; ++i)
-                {
-                    object? obj = payload[i];
-                    if (obj != null)
-                    {
-                        pos = EncodeInBuffer(obj.ToString() ?? "null", true, buffer, pos);
-                    }
-                    else
-                    {
-                        pos = EncodeInBuffer("null", true, buffer, pos);
-                    }
-                }
-            }
-
-            buffer[pos++] = (byte)'\n';
-            int byteCount = pos - 0;
-            if (this.configRefresher.TryGetLogStream(byteCount, out Stream? stream, out int availableByteCount))
-            {
-                if (availableByteCount >= byteCount)
-                {
-                    stream.Write(buffer, 0, byteCount);
-                }
-                else
-                {
-                    stream.Write(buffer, 0, availableByteCount);
-                    stream.Seek(0, SeekOrigin.Begin);
-                    stream.Write(buffer, availableByteCount, byteCount - availableByteCount);
-                }
-            }
-        }
-        catch (Exception)
-        {
-            // Fail to allocate memory for buffer, or
-            // A concurrent condition: memory mapped file is disposed in other thread after TryGetLogStream() finishes.
-            // In this case, silently fail.
-        }
-    }
-
     /// <summary>
     /// Write the <c>datetime</c> formatted string into <c>bytes</c> byte-array starting at <c>byteIndex</c> position.
     /// <para>
@@ -188,7 +133,7 @@ internal void WriteEvent(string? eventMessage, ReadOnlyCollection<object?>? payl
     /// <param name="bytes">Array of bytes to write.</param>
     /// <param name="byteIndex">Starting index into bytes array.</param>
     /// <returns>The number of bytes written.</returns>
-    internal int DateTimeGetBytes(DateTime datetime, byte[] bytes, int byteIndex)
+    internal static int DateTimeGetBytes(DateTime datetime, byte[] bytes, int byteIndex)
     {
         int num;
         int pos = byteIndex;
@@ -271,6 +216,61 @@ internal int DateTimeGetBytes(DateTime datetime, byte[] bytes, int byteIndex)
         return pos - byteIndex;
     }
 
+    internal void WriteEvent(string? eventMessage, ReadOnlyCollection<object?>? payload)
+    {
+        try
+        {
+            var buffer = this.writeBuffer.Value;
+            if (buffer == null)
+            {
+                buffer = new byte[BUFFERSIZE];
+                this.writeBuffer.Value = buffer;
+            }
+
+            var pos = DateTimeGetBytes(DateTime.UtcNow, buffer, 0);
+            buffer[pos++] = (byte)':';
+            pos = EncodeInBuffer(eventMessage, false, buffer, pos);
+            if (payload != null)
+            {
+                // Not using foreach because it can cause allocations
+                for (int i = 0; i < payload.Count; ++i)
+                {
+                    object? obj = payload[i];
+                    if (obj != null)
+                    {
+                        pos = EncodeInBuffer(obj.ToString() ?? "null", true, buffer, pos);
+                    }
+                    else
+                    {
+                        pos = EncodeInBuffer("null", true, buffer, pos);
+                    }
+                }
+            }
+
+            buffer[pos++] = (byte)'\n';
+            int byteCount = pos - 0;
+            if (this.configRefresher.TryGetLogStream(byteCount, out Stream? stream, out int availableByteCount))
+            {
+                if (availableByteCount >= byteCount)
+                {
+                    stream.Write(buffer, 0, byteCount);
+                }
+                else
+                {
+                    stream.Write(buffer, 0, availableByteCount);
+                    stream.Seek(0, SeekOrigin.Begin);
+                    stream.Write(buffer, availableByteCount, byteCount - availableByteCount);
+                }
+            }
+        }
+        catch (Exception)
+        {
+            // Fail to allocate memory for buffer, or
+            // A concurrent condition: memory mapped file is disposed in other thread after TryGetLogStream() finishes.
+            // In this case, silently fail.
+        }
+    }
+
     protected override void OnEventSourceCreated(EventSource eventSource)
     {
         if (eventSource.Name.StartsWith(EventSourceNamePrefix, StringComparison.Ordinal))

src/OpenTelemetry/Logs/ILogger/OpenTelemetryLoggerProvider.cs

@@ -18,7 +18,7 @@ public class OpenTelemetryLoggerProvider : BaseProvider, ILoggerProvider, ISuppo
 {
     internal readonly LoggerProvider Provider;
     private readonly bool ownsProvider;
-    private readonly Hashtable loggers = new();
+    private readonly Hashtable loggers = [];
     private bool disposed;
 
     static OpenTelemetryLoggerProvider()

src/OpenTelemetry/Logs/LoggerProviderSdk.cs

@@ -88,13 +88,36 @@ public LoggerProviderSdk(
 
     public ILogRecordPool LogRecordPool => this.threadStaticPool ?? LogRecordSharedPool.Current;
 
+    public static bool ContainsBatchProcessor(BaseProcessor<LogRecord> processor)
+    {
+        if (processor is BatchExportProcessor<LogRecord>)
+        {
+            return true;
+        }
+        else if (processor is CompositeProcessor<LogRecord> compositeProcessor)
+        {
+            var current = compositeProcessor.Head;
+            while (current != null)
+            {
+                if (ContainsBatchProcessor(current.Value))
+                {
+                    return true;
+                }
+
+                current = current.Next;
+            }
+        }
+
+        return false;
+    }
+
     public void AddProcessor(BaseProcessor<LogRecord> processor)
     {
         Guard.ThrowIfNull(processor);
 
         processor.SetParentProvider(this);
 
-        if (this.threadStaticPool != null && this.ContainsBatchProcessor(processor))
+        if (this.threadStaticPool != null && ContainsBatchProcessor(processor))
         {
             OpenTelemetrySdkEventSource.Log.LoggerProviderSdkEvent("Using shared thread pool.");
 
@@ -168,29 +191,6 @@ public bool Shutdown(int timeoutMilliseconds)
         }
     }
 
-    public bool ContainsBatchProcessor(BaseProcessor<LogRecord> processor)
-    {
-        if (processor is BatchExportProcessor<LogRecord>)
-        {
-            return true;
-        }
-        else if (processor is CompositeProcessor<LogRecord> compositeProcessor)
-        {
-            var current = compositeProcessor.Head;
-            while (current != null)
-            {
-                if (this.ContainsBatchProcessor(current.Value))
-                {
-                    return true;
-                }
-
-                current = current.Next;
-            }
-        }
-
-        return false;
-    }
-
     /// <inheritdoc />
 #if EXPOSE_EXPERIMENTAL_FEATURES
     protected

src/OpenTelemetry/Metrics/AggregationTemporality.cs

@@ -7,7 +7,11 @@ namespace OpenTelemetry.Metrics;
 /// Enumeration used to define the aggregation temporality for a <see
 /// cref="Metric"/>.
 /// </summary>
+#pragma warning disable CA1008 // Enums should have zero value
+#pragma warning disable CA1028 // Enum storage should be Int32
 public enum AggregationTemporality : byte
+#pragma warning restore CA1028 // Enum storage should be Int32
+#pragma warning restore CA1008 // Enums should have zero value
 {
     /// <summary>
     /// Cumulative.

src/OpenTelemetry/Metrics/AggregatorStore.cs

@@ -23,7 +23,7 @@ internal sealed class AggregatorStore
     internal readonly int NumberOfMetricPoints;
     internal readonly ConcurrentDictionary<Tags, LookupData>? TagsToMetricPointIndexDictionaryDelta;
     internal readonly Func<ExemplarReservoir?>? ExemplarReservoirFactory;
-    internal long DroppedMeasurements = 0;
+    internal long DroppedMeasurements;
 
     private const ExemplarFilterType DefaultExemplarFilter = ExemplarFilterType.AlwaysOff;
     private static readonly Comparison<KeyValuePair<string, object?>> DimensionComparisonDelegate = (x, y) => x.Key.CompareTo(y.Key);
@@ -50,8 +50,8 @@ internal sealed class AggregatorStore
     private readonly ExemplarFilterType exemplarFilter;
     private readonly Func<KeyValuePair<string, object?>[], int, int> lookupAggregatorStore;
 
-    private int metricPointIndex = 0;
-    private int batchSize = 0;
+    private int metricPointIndex;
+    private int batchSize;
     private bool zeroTagMetricPointInitialized;
     private bool overflowTagMetricPointInitialized;
 

src/OpenTelemetry/Metrics/Builder/MeterProviderBuilderExtensions.cs

@@ -108,7 +108,7 @@ public static MeterProviderBuilder AddView(this MeterProviderBuilder meterProvid
             throw new ArgumentException($"Custom view name {name} is invalid.", nameof(name));
         }
 
-        if (instrumentName.IndexOf('*') != -1)
+        if (instrumentName.Contains('*'))
         {
             throw new ArgumentException(
                 $"Instrument selection criteria is invalid. Instrument name '{instrumentName}' " +
@@ -136,7 +136,7 @@ public static MeterProviderBuilder AddView(this MeterProviderBuilder meterProvid
         Guard.ThrowIfNullOrWhitespace(instrumentName);
         Guard.ThrowIfNull(metricStreamConfiguration);
 
-        if (metricStreamConfiguration.Name != null && instrumentName.IndexOf('*') != -1)
+        if (metricStreamConfiguration.Name != null && instrumentName.Contains('*'))
         {
             throw new ArgumentException(
                 $"Instrument selection criteria is invalid. Instrument name '{instrumentName}' " +
@@ -149,7 +149,7 @@ public static MeterProviderBuilder AddView(this MeterProviderBuilder meterProvid
         {
             if (builder is MeterProviderBuilderSdk meterProviderBuilderSdk)
             {
-                if (instrumentName.IndexOf('*') != -1)
+                if (instrumentName.Contains('*'))
                 {
                     var pattern = '^' + Regex.Escape(instrumentName).Replace("\\*", ".*");
                     var regex = new Regex(pattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);