Skip to content

Commit 12323f8

Browse files
committed
*: tiny updates, more logs
1 parent 0c93618 commit 12323f8

File tree

4 files changed

+20
-11
lines changed

4 files changed

+20
-11
lines changed

cmd/dashboard/main.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
func main() {
2626
const usage = `
2727
Usage:
28-
codis-dashboard [--ncpu=N] [--config=CONF] [--log=FILE] [--log-level=LEVEL] [--host-admin=ADDR] [--zookeeper=ADDR|--etcd=ADDR|--filesystem=ROOT] [--product_name=NAME] [--product_auth=AUTH] [--pidfile=FILE] [--remove-lock]
28+
codis-dashboard [--ncpu=N] [--config=CONF] [--log=FILE] [--log-level=LEVEL] [--host-admin=ADDR] [--pidfile=FILE] [--zookeeper=ADDR|--etcd=ADDR|--filesystem=ROOT] [--product_name=NAME] [--product_auth=AUTH] [--remove-lock]
2929
codis-dashboard --default-config
3030
codis-dashboard --version
3131
@@ -92,17 +92,23 @@ Options:
9292
case d["--zookeeper"] != nil:
9393
config.CoordinatorName = "zookeeper"
9494
config.CoordinatorAddr = utils.ArgumentMust(d, "--zookeeper")
95+
log.Warnf("option --zookeeper = %s", config.CoordinatorAddr)
96+
9597
case d["--etcd"] != nil:
9698
config.CoordinatorName = "etcd"
9799
config.CoordinatorAddr = utils.ArgumentMust(d, "--etcd")
100+
log.Warnf("option --etcd = %s", config.CoordinatorAddr)
101+
98102
case d["--filesystem"] != nil:
99103
config.CoordinatorName = "filesystem"
100104
config.CoordinatorAddr = utils.ArgumentMust(d, "--filesystem")
105+
log.Warnf("option --filesystem = %s", config.CoordinatorAddr)
106+
101107
}
102108

103109
if s, ok := utils.Argument(d, "--product_name"); ok {
104110
config.ProductName = s
105-
log.Warnf("option --product_nam = %s", s)
111+
log.Warnf("option --product_name = %s", s)
106112
}
107113
if s, ok := utils.Argument(d, "--product_auth"); ok {
108114
config.ProductAuth = s

cmd/ha/main.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ Options:
6666
log.Warnf("set dashboard = %s", dashboard)
6767
log.Warnf("set interval = %d (seconds)", interval)
6868

69-
var noMaintains = false
69+
var maintains = true
7070
if d["--no-maintains"].(bool) {
71-
noMaintains = true
71+
maintains = false
7272
}
7373

7474
client := topom.NewApiClient(dashboard)
@@ -91,7 +91,7 @@ Options:
9191
hc := newHealthyChecker(client)
9292
hc.LogProxyStats()
9393
hc.LogGroupStats()
94-
if !noMaintains {
94+
if maintains {
9595
hc.Maintains(client, interval*10, prodcutAuth)
9696
}
9797

cmd/proxy/main.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
func main() {
3232
const usage = `
3333
Usage:
34-
codis-proxy [--ncpu=N [--max-ncpu=MAX]] [--config=CONF] [--log=FILE] [--log-level=LEVEL] [--host-admin=ADDR] [--host-proxy=ADDR] [--dashboard=ADDR|--zookeeper=ADDR|--etcd=ADDR|--filesystem=ROOT|--fillslots=FILE] [--ulimit=NLIMIT] [--product_name=NAME] [--product_auth=AUTH] [--pidfile=FILE]
34+
codis-proxy [--ncpu=N [--max-ncpu=MAX]] [--config=CONF] [--log=FILE] [--log-level=LEVEL] [--host-admin=ADDR] [--host-proxy=ADDR] [--dashboard=ADDR|--zookeeper=ADDR|--etcd=ADDR|--filesystem=ROOT|--fillslots=FILE] [--ulimit=NLIMIT] [--pidfile=FILE] [--product_name=NAME] [--product_auth=AUTH] [--session_auth=AUTH]
3535
codis-proxy --default-config
3636
codis-proxy --version
3737
@@ -166,12 +166,16 @@ Options:
166166

167167
if s, ok := utils.Argument(d, "--product_name"); ok {
168168
config.ProductName = s
169-
log.Warnf("option --product_nam = %s", s)
169+
log.Warnf("option --product_name = %s", s)
170170
}
171171
if s, ok := utils.Argument(d, "--product_auth"); ok {
172172
config.ProductAuth = s
173173
log.Warnf("option --product_auth = %s", s)
174174
}
175+
if s, ok := utils.Argument(d, "--session_auth"); ok {
176+
config.SessionAuth = s
177+
log.Warnf("option --session_auth = %s", s)
178+
}
175179

176180
s, err := proxy.New(config)
177181
if err != nil {

kubernetes/start.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ scale-server)
5959
while [ $(kubectl get pods -l app=codis-server |grep Running |wc -l) != $2 ]; do sleep 1; done;
6060
kubectl exec -it codis-server-0 -- codis-admin --dashboard=codis-dashboard:18080 --rebalance --confirm
6161
else
62-
echo "reduce the number of codis-server, does not support, plz wait"
62+
echo "reduce the number of codis-server, does not support, please wait"
6363
# while [ $cur > $des ]
6464
# do
6565
# cur=`expr $cur - 2`
@@ -72,11 +72,10 @@ scale-server)
7272
# kubectl scale statefulsets codis-server --replicas=$des
7373
# kubectl exec -it codis-server-0 -- codis-admin --dashboard=codis-dashboard:18080 --rebalance --confirm
7474
fi
75-
76-
;;
75+
;;
7776

7877
*)
7978
echo "wrong argument(s)"
8079
;;
8180

82-
esac
81+
esac

0 commit comments

Comments
 (0)