refactor: improve error handling with anyhow

Author: reddevilmidzy

Cargo.toml

@@ -11,6 +11,7 @@ path = "src/main.rs"
 name = "coduck-backend"
 
 [dependencies]
+anyhow = "1.0"
 axum = { version = "0.8.4", features = ["json", "multipart"] }
 chrono = { version = "0.4.38", features = ["serde"] }
 reqwest = { version = "0.12.19", features = ["json", "rustls-tls"] }

src/file_manager/handlers.rs

@@ -2,32 +2,49 @@ use crate::file_manager::{
     FileMetadata, Language, UpdateFileContentRequest, UpdateFilenameRequest,
 };
 
+use anyhow::{anyhow, Result};
 use axum::{
     extract::{Multipart, Path},
+    http::StatusCode,
     response::IntoResponse,
     Json,
 };
 use chrono::Utc;
-use reqwest::StatusCode;
 use std::path::PathBuf;
 use tokio::fs;
 use uuid::Uuid;
 
 const UPLOAD_DIR: &str = "uploads";
 
+async fn file_exists(file_path: &PathBuf) -> bool {
+    tokio::fs::metadata(file_path).await.is_ok()
+}
+
 pub async fn upload_file(
     Path((problem_id, category)): Path<(u32, String)>,
-    mut multipart: Multipart,
+    multipart: Multipart,
 ) -> impl IntoResponse {
-    let field = multipart.next_field().await.unwrap().unwrap();
-    let file_name = field.file_name().unwrap().to_string();
-    let data = field.bytes().await.unwrap();
+    let (file_name, data) = match extract_multipart_data(multipart).await {
+        Ok(data) => data,
+        Err(e) => {
+            return (
+                StatusCode::BAD_REQUEST,
+                Json(serde_json::json!({
+                    "error": e.to_string()
+                })),
+            )
+                .into_response();
+        }
+    };
+
     let file_id = Uuid::new_v4().to_string();
-    let upload_dir = PathBuf::from(format!("{}/{}/{}", UPLOAD_DIR, problem_id, category));
+    let upload_dir = PathBuf::from(UPLOAD_DIR)
+        .join(problem_id.to_string())
+        .join(&category);
 
     let file_path = upload_dir.join(&file_name);
 
-    if file_path.exists() {
+    if file_exists(&file_path).await {
         return (
             StatusCode::CONFLICT,
             Json(serde_json::json!({
@@ -51,8 +68,16 @@ pub async fn upload_file(
         }
     };
 
-    fs::create_dir_all(&upload_dir).await.unwrap();
-    fs::write(&file_path, &data).await.unwrap();
+    if let Err(e) = save_file(&upload_dir, &file_path, &data).await {
+        return (
+            StatusCode::INTERNAL_SERVER_ERROR,
+            Json(serde_json::json!({
+                "error": e.to_string()
+            })),
+        )
+            .into_response();
+    }
+
     let metadata = FileMetadata {
         id: file_id,
         filename: file_name,
@@ -65,15 +90,47 @@ pub async fn upload_file(
     (StatusCode::CREATED, Json(metadata)).into_response()
 }
 
+async fn save_file(
+    upload_dir: &PathBuf,
+    file_path: &PathBuf,
+    data: &axum::body::Bytes,
+) -> Result<()> {
+    fs::create_dir_all(upload_dir)
+        .await
+        .map_err(|_| anyhow!("Failed to create directory"))?;
+
+    fs::write(file_path, data)
+        .await
+        .map_err(|_| anyhow!("Failed to write file"))?;
+
+    Ok(())
+}
+
+async fn extract_multipart_data(mut multipart: Multipart) -> Result<(String, axum::body::Bytes)> {
+    let field = multipart
+        .next_field()
+        .await?
+        .ok_or_else(|| anyhow!("Missing multipart field"))?;
+
+    let file_name = field
+        .file_name()
+        .ok_or_else(|| anyhow!("Missing file name in multipart field"))?
+        .to_string();
+
+    let data = field.bytes().await?;
+
+    Ok((file_name, data))
+}
+
 pub async fn get_file(
     Path((problem_id, category, filename)): Path<(u32, String, String)>,
 ) -> impl IntoResponse {
-    let file_path = PathBuf::from(format!(
-        "{}/{}/{}/{}",
-        UPLOAD_DIR, problem_id, category, filename
-    ));
+    let file_path = PathBuf::from(UPLOAD_DIR)
+        .join(problem_id.to_string())
+        .join(&category)
+        .join(&filename);
 
-    if !file_path.exists() {
+    if !file_exists(&file_path).await {
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
@@ -107,9 +164,11 @@ pub async fn get_file(
 pub async fn get_files_by_category(
     Path((problem_id, category)): Path<(u32, String)>,
 ) -> impl IntoResponse {
-    let category_dir = PathBuf::from(format!("{}/{}/{}", UPLOAD_DIR, problem_id, category));
+    let category_dir = PathBuf::from(UPLOAD_DIR)
+        .join(problem_id.to_string())
+        .join(&category);
 
-    if !category_dir.exists() {
+    if !file_exists(&category_dir).await {
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
@@ -149,12 +208,12 @@ pub async fn get_files_by_category(
 pub async fn delete_file(
     Path((problem_id, category, filename)): Path<(u32, String, String)>,
 ) -> impl IntoResponse {
-    let file_path = PathBuf::from(format!(
-        "{}/{}/{}/{}",
-        UPLOAD_DIR, problem_id, category, filename
-    ));
+    let file_path = PathBuf::from(UPLOAD_DIR)
+        .join(problem_id.to_string())
+        .join(&category)
+        .join(&filename);
 
-    if !file_path.exists() {
+    if !file_exists(&file_path).await {
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
@@ -186,12 +245,12 @@ pub async fn update_file_content(
     Path((problem_id, category, filename)): Path<(u32, String, String)>,
     Json(update_request): Json<UpdateFileContentRequest>,
 ) -> impl IntoResponse {
-    let file_path = PathBuf::from(format!(
-        "{}/{}/{}/{}",
-        UPLOAD_DIR, problem_id, category, filename
-    ));
+    let file_path = PathBuf::from(UPLOAD_DIR)
+        .join(problem_id.to_string())
+        .join(&category)
+        .join(&filename);
 
-    if !file_path.exists() {
+    if !file_exists(&file_path).await {
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
@@ -223,12 +282,12 @@ pub async fn update_filename(
     Path((problem_id, category)): Path<(u32, String)>,
     Json(update_request): Json<UpdateFilenameRequest>,
 ) -> impl IntoResponse {
-    let file_path = PathBuf::from(format!(
-        "{}/{}/{}/{}",
-        UPLOAD_DIR, problem_id, category, update_request.old_filename
-    ));
+    let file_path = PathBuf::from(UPLOAD_DIR)
+        .join(problem_id.to_string())
+        .join(&category)
+        .join(&update_request.old_filename);
 
-    if !file_path.exists() {
+    if !file_exists(&file_path).await {
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({