Downloader - Silently return no repos when incorrect permissions

[PredaaA]

What Red version are you using?

3.5.22

Cog name

Downloader

Command name

repo list or cog update

What did you expect to happen?

To list the repos available or update the cogs.
Or if the permissions are wrong, to send something or log it in the console.

What actually happened?

It returns "There are no repos installed." or "There were no cogs to check."

How can we reproduce this error?

1. Change the owner of the repos folder. (Eg: chown debian:debian repos)
2. Restart the bot.
3. Use the repo list or cog update command.

Anything else?

No response

[Flame442]

These commands use the value stored in self._repo_manager.repos, which is generated by a call to _load_repos and maintained as changes are made. My best guess as to what is causing this issue is the sweeping exception handling in _load_repos causing repos to be omitted from this cache if some kind of failure happens. I would expect a warning or error in console when starting the bot if this were the case. If so, this isn't happening silently, but it is likely hidden within the startup garbage dump and hard to notice.

Red-DiscordBot/redbot/cogs/downloader/repo_manager.py

Lines 1227 to 1246 in dd3b9a0

	async def _load_repos(self, set_repos: bool = False) -> Dict[str, Repo]:
	ret = {}
	self.repos_folder.mkdir(parents=True, exist_ok=True)
	for folder in self.repos_folder.iterdir():
	if not folder.is_dir():
	continue
	try:
	branch = await self.config.repos.get_raw(folder.name, default="")
	ret[folder.name] = await Repo.from_folder(folder, branch)
	if branch == "":
	await self.config.repos.set_raw(folder.name, value=ret[folder.name].branch)
	except errors.NoRemoteURL:
	log.warning("A remote URL does not exist for repo %s", folder.name)
	except errors.DownloaderException as err:
	log.error("Ignoring repo %s due to error.", folder.name, exc_info=err)
	# Downloader should NOT remove the repo on generic errors like this one.
	# We were removing whole repo folder here in the past,
	# but it's quite destructive for such a generic error.
	# We can't **expect** that this error will always mean git repository is broken.
	# GH-3867

This does not seem like a likely issue to encounter, since this is a folder created and managed by Downloader that I would not expect a user to specifically change the permissions of. If the entire datapath were to have its permissions changed, I would expect a crash somewhere else in the startup process that would be much more noticeable than this issue. I'm not sure what an appropriate level of feedback would be beyond what is already given.