Skip to content

Commit f4fb0ff

Browse files
committed
compose: Unset 'container_name' for all services
Remove hardcoded container names from all services in the docker-compose files to allow multiple instances of the same service to run in parallel without conflicts. This is important to allow both scaling individual services as well as running multiple instances of the CMS stack locally for testing purposes. Signed-off-by: Phoevos Kalemkeris <[email protected]>
1 parent ac0a8c1 commit f4fb0ff

9 files changed

+17
-31
lines changed

docker-compose-auth.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ services:
44

55
auth-db:
66
image: postgres:14
7-
container_name: cms_auth-db
87
restart: always
98
networks:
109
- cogstack-model-serve_cms

docker-compose-celery.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ services:
1212
- HTTP_PROXY=$HTTP_PROXY
1313
- HTTPS_PROXY=$HTTPS_PROXY
1414
- NO_PROXY=$NO_PROXY
15-
container_name: cms_worker
1615
networks:
1716
- cms
1817
volumes:
@@ -32,7 +31,6 @@ services:
3231
build:
3332
context: ./
3433
dockerfile: ./docker/celery/Dockerfile-Dashboard
35-
container_name: cms_worker_dashboard
3634
networks:
3735
- cms
3836
ports:
@@ -45,7 +43,6 @@ services:
4543

4644
redis:
4745
image: redis:7
48-
container_name: cms_redis
4946
networks:
5047
- cms
5148
ports:

docker-compose-dev.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ services:
88
file: ./docker-compose.yml
99
service: medcat-snomed
1010
image: cogstack-model-serve_medcat-snomed:dev
11-
container_name: dev-cms_medcat-snomed
11+
labels:
12+
- org.cogstack.model-serve.env=dev
1213
volumes:
1314
- ${MODEL_PACKAGE_FULL_PATH}:/app/model/model.zip:ro
1415
environment:
@@ -37,7 +38,8 @@ services:
3738
file: ./docker-compose.yml
3839
service: medcat-icd10
3940
image: cogstack-model-serve_medcat-icd10:dev
40-
container_name: dev-cms_medcat-icd10
41+
labels:
42+
- org.cogstack.model-serve.env=dev
4143
environment:
4244
- BASE_MODEL_FULL_PATH=$MODEL_PACKAGE_FULL_PATH
4345
- AWS_ACCESS_KEY_ID=
@@ -64,7 +66,8 @@ services:
6466
file: ./docker-compose.yml
6567
service: de-identification
6668
image: cogstack-model-serve_de-identification:dev
67-
container_name: dev-cms_trf-deid
69+
labels:
70+
- org.cogstack.model-serve.env=dev
6871
environment:
6972
- BASE_MODEL_FULL_PATH=$MODEL_PACKAGE_FULL_PATH
7073
- AWS_ACCESS_KEY_ID=
@@ -91,7 +94,8 @@ services:
9194
file: ./docker-compose.yml
9295
service: medcat-deid
9396
image: cogstack-model-serve_medcat-deid:dev
94-
container_name: dev-cms_medcat-deid
97+
labels:
98+
- org.cogstack.model-serve.env=dev
9599
environment:
96100
- BASE_MODEL_FULL_PATH=$MODEL_PACKAGE_FULL_PATH
97101
- AWS_ACCESS_KEY_ID=
@@ -118,7 +122,8 @@ services:
118122
file: ./docker-compose.yml
119123
service: medcat-umls
120124
image: cogstack-model-serve_medcat-umls:dev
121-
container_name: dev-cms_medcat-umls
125+
labels:
126+
- org.cogstack.model-serve.env=dev
122127
environment:
123128
- BASE_MODEL_FULL_PATH=$MODEL_PACKAGE_FULL_PATH
124129
- AWS_ACCESS_KEY_ID=

docker-compose-log.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ services:
44

55
mongodb:
66
image: mongo:5.0
7-
container_name: cms_mongodb
87
volumes:
98
- mongodb_data:/data/db
109
restart: always
@@ -20,7 +19,6 @@ services:
2019

2120
opensearch:
2221
image: opensearchproject/opensearch:2.4.0
23-
container_name: cms_opensearch
2422
environment:
2523
- OPENSEARCH_JAVA_OPTS=-Xms1g -Xmx1g
2624
- bootstrap.memory_lock=true
@@ -47,7 +45,6 @@ services:
4745

4846
graylog:
4947
image: graylog/graylog:5.0
50-
container_name: cms_graylog
5148
depends_on:
5249
opensearch:
5350
condition: "service_healthy"

docker-compose-mlflow.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ services:
44

55
mlflow-db:
66
image: postgres:14
7-
container_name: cms_mlflow-db
87
restart: always
98
networks:
109
- cogstack-model-serve_cms
@@ -24,7 +23,6 @@ services:
2423

2524
minio:
2625
image: minio/minio:RELEASE.2022-06-30T20-58-09Z
27-
container_name: cms_minio
2826
restart: always
2927
networks:
3028
- cogstack-model-serve_cms
@@ -71,7 +69,6 @@ services:
7169
- HTTP_PROXY=$HTTP_PROXY
7270
- HTTPS_PROXY=$HTTPS_PROXY
7371
- NO_PROXY=$NO_PROXY
74-
container_name: cms_mlflow-ui
7572
restart: always
7673
networks:
7774
- cogstack-model-serve_cms
@@ -80,7 +77,7 @@ services:
8077
environment:
8178
- MLFLOW_DB_USERNAME=$MLFLOW_DB_USERNAME
8279
- MLFLOW_DB_PASSWORD=$MLFLOW_DB_PASSWORD
83-
- MLFLOW_BACKEND_STORE_URI=postgresql://$MLFLOW_DB_USERNAME:$MLFLOW_DB_PASSWORD@cms_mlflow-db:5432/mlflow-backend-store
80+
- MLFLOW_BACKEND_STORE_URI=postgresql://$MLFLOW_DB_USERNAME:$MLFLOW_DB_PASSWORD@mlflow-db:5432/mlflow-backend-store
8481
- MLFLOW_TRACKING_URI=http://localhost:5000
8582
- ARTIFACTS_DESTINATION=s3://cms-model-bucket
8683
- MLFLOW_S3_ENDPOINT_URL=http://minio:9000
@@ -121,7 +118,6 @@ services:
121118
- NO_PROXY=$NO_PROXY
122119
profiles:
123120
- wip
124-
container_name: cms_mlflow-deployments
125121
restart: always
126122
networks:
127123
- cogstack-model-serve_cms
@@ -153,7 +149,8 @@ services:
153149
- NO_PROXY=$NO_PROXY
154150
profiles:
155151
- wip
156-
container_name: cms_mlflow-${MODEL_NAME:-model}
152+
labels:
153+
- org.cogstack.model-serve.model-name=${MODEL_NAME:-model}
157154
restart: always
158155
networks:
159156
- cogstack-model-serve_cms

docker-compose-mon.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ services:
44

55
prometheus:
66
image: prom/prometheus:v2.41.0
7-
container_name: cms_prometheus
87
restart: always
98
networks:
109
- cogstack-model-serve_cms
@@ -29,7 +28,6 @@ services:
2928

3029
grafana:
3130
image: grafana/grafana:9.3.2-ubuntu
32-
container_name: cms_grafana
3331
restart: always
3432
networks:
3533
- cogstack-model-serve_cms
@@ -51,7 +49,6 @@ services:
5149

5250
alertmanager:
5351
image: prom/alertmanager:v0.25.0
54-
container_name: cms_alertmanager
5552
restart: always
5653
networks:
5754
- cogstack-model-serve_cms
@@ -73,7 +70,6 @@ services:
7370

7471
cadvisor:
7572
image: gcr.io/cadvisor/cadvisor:v0.46.0
76-
container_name: cms_cadvisor
7773
restart: always
7874
networks:
7975
- cogstack-model-serve_cms

docker-compose-proxy.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ services:
1010
- HTTP_PROXY=$HTTP_PROXY
1111
- HTTPS_PROXY=$HTTPS_PROXY
1212
- NO_PROXY=$NO_PROXY
13-
container_name: cms_proxy
1413
restart: always
1514
networks:
1615
- cogstack-model-serve_cms

docker-compose.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ services:
1313
- HTTP_PROXY=$HTTP_PROXY
1414
- HTTPS_PROXY=$HTTPS_PROXY
1515
- NO_PROXY=$NO_PROXY
16-
container_name: cms_medcat-snomed
1716
restart: always
1817
networks:
1918
- cms
@@ -63,7 +62,6 @@ services:
6362
- HTTP_PROXY=$HTTP_PROXY
6463
- HTTPS_PROXY=$HTTPS_PROXY
6564
- NO_PROXY=$NO_PROXY
66-
container_name: cms_medcat-icd10
6765
restart: always
6866
networks:
6967
- cms
@@ -113,7 +111,6 @@ services:
113111
- HTTP_PROXY=$HTTP_PROXY
114112
- HTTPS_PROXY=$HTTPS_PROXY
115113
- NO_PROXY=$NO_PROXY
116-
container_name: cms_trf-deid
117114
restart: always
118115
networks:
119116
- cms
@@ -162,7 +159,6 @@ services:
162159
- HTTP_PROXY=$HTTP_PROXY
163160
- HTTPS_PROXY=$HTTPS_PROXY
164161
- NO_PROXY=$NO_PROXY
165-
container_name: cms_medcat-deid
166162
restart: always
167163
networks:
168164
- cms
@@ -212,7 +208,6 @@ services:
212208
- HTTP_PROXY=$HTTP_PROXY
213209
- HTTPS_PROXY=$HTTPS_PROXY
214210
- NO_PROXY=$NO_PROXY
215-
container_name: cms_medcat-umls
216211
restart: always
217212
networks:
218213
- cms
@@ -262,7 +257,6 @@ services:
262257
- HTTP_PROXY=$HTTP_PROXY
263258
- HTTPS_PROXY=$HTTPS_PROXY
264259
- NO_PROXY=$NO_PROXY
265-
container_name: cms_huggingface-ner
266260
restart: always
267261
networks:
268262
- cms

tests/load/docker-compose.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ version: "3"
33
services:
44
master:
55
image: locustio/locust:2.26.0
6-
container_name: cms_load_master
6+
labels:
7+
- org.cogstack.model-serve.locust=master
78
networks:
89
- cogstack-model-serve_cms
910
ports:
@@ -25,7 +26,8 @@ services:
2526

2627
worker:
2728
image: locustio/locust:2.26.0
28-
container_name: cms_load_worker
29+
labels:
30+
- org.cogstack.model-serve.locust=worker
2931
networks:
3032
- cogstack-model-serve_cms
3133
environment:

0 commit comments

Comments
 (0)