Feedback on Detected SUSPICIOUS-COMMENTS

[zyue110026]

Greetings,

We are some security researchers who have built a scanner to detect known security weaknesses. For your repository, we have found instances of SUSPICIOUS-COMMENTS in the following locations:

Location-1:

CoherentStructures.jl/src/gridfunctions.jl

Line 41 in d90f745

mutable struct GridContext{dim,G<:FEM.Grid,ITP<:FEM.Interpolation,ITPG<:FEM.Interpolation,DH<:FEM.DofHandler,QR<:FEM.QuadratureRule,PL<:PointLocator} <: AbstractGridContext{dim} #TODO: Currently set as mutable, is this sensible?

Location-2:

CoherentStructures.jl/src/gridfunctions.jl

Line 496 in d90f745

#TODO: Think about what values would be sensible for the two variables below

Location-3:

CoherentStructures.jl/src/gridfunctions.jl

Line 820 in d90f745

#TODO: replace this with a macro maybe

Location-4:

CoherentStructures.jl/src/gridfunctions.jl

Line 826 in d90f745

#TODO: replace this with a macro maybe

Location-5:

CoherentStructures.jl/src/gridfunctions.jl

Line 1117 in d90f745

#TODO: Maybe make this more efficient by calling evaluate_function_from_node_or_cellvals_multiple

Location-6:

CoherentStructures.jl/src/gridfunctions.jl

Line 1183 in d90f745

@assert what ∈ [0,-1,1] #TODO: get rid of this

Location-7:

CoherentStructures.jl/src/gridfunctions.jl

Line 1217 in d90f745

#TODO: optimize this for speed

Location-8:

CoherentStructures.jl/src/gridfunctions.jl

Line 1413 in d90f745

facesets = Dict{String,Set{Tuple{Int,Int}}}()#TODO:Does it make sense to add to this?

Location-9:

CoherentStructures.jl/src/gridfunctions.jl

Line 1414 in d90f745

#boundary_matrix = spzeros(Bool, 3, m)#TODO:Maybe treat the boundary correctly?

Location-10:

CoherentStructures.jl/src/gridfunctions.jl

Line 1415 in d90f745

#TODO: Fix below if this doesn't work

Location-11:

CoherentStructures.jl/src/gridfunctions.jl

Line 1476 in d90f745

#facesets = Dict{String,Set{Tuple{Int,Int}}}()#TODO:Does it make sense to add to this?

Location-12:

CoherentStructures.jl/src/gridfunctions.jl

Line 1477 in d90f745

#boundary_matrix = spzeros(Bool, 3, m)#TODO:Maybe treat the boundary correctly?

Location-13:

CoherentStructures.jl/src/gridfunctions.jl

Line 1478 in d90f745

#TODO: Fix below if this doesn't work

Location-14:

CoherentStructures.jl/src/gridfunctions.jl

Line 1511 in d90f745

#TODO: See if this can be moved upstream

Location-15:

CoherentStructures.jl/src/gridfunctions.jl

Line 1558 in d90f745

#TODO add @inbounds once this works...

Location-16:

CoherentStructures.jl/src/gridfunctions.jl

Line 87 in d90f745

#TODO: Measure if the sorting below is expensive

Location-17:

CoherentStructures.jl/src/gridfunctions.jl

Line 269 in d90f745

# TODO: unclear what this function is good for... completely type unstable!

Please give us feedback. Do you think these are valid instances on security weaknesses? Will you fix them?