Skip to content

Commit 0131d7e

Browse files
committed
Note on edge case test being disabled after JDK 22 update
1 parent 905d881 commit 0131d7e

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

jreleaser.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ project:
1010
inceptionYear: 2022
1111
stereotype: none
1212
java:
13-
version: 11
13+
version: 22
1414
groupId: software.coley
1515
artifactId: lljzip
1616

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@
9797
<plugin>
9898
<groupId>org.apache.maven.plugins</groupId>
9999
<artifactId>maven-compiler-plugin</artifactId>
100+
<version>3.13.0</version>
100101
<configuration>
101-
<source>22</source>
102-
<target>22</target>
102+
<release>22</release>
103103
</configuration>
104104
</plugin>
105105
<plugin>

src/test/java/software/coley/lljzip/JvmVsZipFileEqualityEdgeCaseTests.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package software.coley.lljzip;
22

3+
import org.junit.jupiter.api.Disabled;
34
import org.junit.jupiter.params.ParameterizedTest;
45
import org.junit.jupiter.params.provider.ValueSource;
56
import software.coley.lljzip.format.model.AbstractZipFileHeader;
@@ -13,15 +14,16 @@
1314
import java.util.stream.Collectors;
1415
import java.util.zip.ZipFile;
1516

16-
import static org.junit.jupiter.api.Assertions.*;
17+
import static org.junit.jupiter.api.Assertions.assertEquals;
18+
import static org.junit.jupiter.api.Assertions.fail;
1719

1820
/**
1921
* Some edge case tests where {@link JvmZipReader} needs to match a few quirky cases from {@link ZipFile}.
2022
*
2123
* @author Matt Coley
2224
*/
2325
public class JvmVsZipFileEqualityEdgeCaseTests {
24-
26+
@Disabled("Updating to JDK changes how ZipFile works, which no longer reads the test sample")
2527
@ParameterizedTest
2628
@ValueSource(strings = {
2729
"resource-pack-trick-header-N-to-1-cen-to-loc-mapping.zip",
@@ -43,7 +45,7 @@ public void test(String name) {
4345
assertEquals(0, namesDifference.size());
4446
assertEquals(sizeDel, sizeJvm);
4547
} catch (Exception ex) {
46-
ex.printStackTrace();
48+
fail(ex);
4749
}
4850
}
4951
}

0 commit comments

Comments
 (0)